Skip to content

Import JSON in Typescript #25516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sorenlouv wants to merge 1 commit into from
Closed

Import JSON in Typescript #25516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/dev/typescript/projects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ export function filterProjectsByFlag(projectFlag?: string) {
}

const tsConfigPath = resolve(projectFlag);
return PROJECTS.filter(project => project.tsConfigPath === tsConfigPath);
return PROJECTS.filter(project => project.tsConfigPath.includes(tsConfigPath));
Copy link
Copy Markdown
Contributor Author

@sorenlouv sorenlouv Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it useful to be able to run tslint for x-pack like this:
node scripts/tslint --project x-pack

Is that okay, or should I revert this change?

Copy link
Copy Markdown
Contributor

@spalger spalger Nov 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be fine with something a little bit stricter, maybe:

project.tsConfigPath === tsConfigPath || project.tsConfigPath === resolve(tsConfigPath, 'tsconfig.json')

Pretty sure as is --project . will match any tsconfig.json file, depending on which one is first.

}
4 changes: 4 additions & 0 deletions tslint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,7 @@ rules:
* specific language governing permissions and limitations
* under the License.
*/

linterOptions:
exclude:
- ./**/*.json
13 changes: 0 additions & 13 deletions x-pack/plugins/apm/typings/global_types.d.ts
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions x-pack/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"test/**/*"
],
"compilerOptions": {
"resolveJsonModule": true,
Copy link
Copy Markdown
Contributor Author

@sorenlouv sorenlouv Nov 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially added this to kibana/tsconfig.json but it caused problems in kbn-pm/tsconfig.json and kibana/tsconfig.browser.json since they do not emit commonjs. I can probably override this with "resolveJsonModule": false if necessary.

Copy link
Copy Markdown
Contributor

@spalger spalger Nov 13, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wouldn't mind setting this in the root config and negating it where necessary that would keep the compilerOptions a little more consistent across projects, which is desirable.

"paths": {
"ui/*": [
"src/ui/public/*"
Expand Down