Skip to content

[Lens] TypeScript v5.9.3 fixes#254898

Draft
walterra wants to merge 7 commits intoelastic:mainfrom
walterra:lens-ts-fixes
Draft

[Lens] TypeScript v5.9.3 fixes#254898
walterra wants to merge 7 commits intoelastic:mainfrom
walterra:lens-ts-fixes

Conversation

@walterra
Copy link
Copy Markdown
Contributor

@walterra walterra commented Feb 25, 2026

Summary

Follow up to #239670.
Fixes #255571.

Fixes TypeScript errors in the Lens plugin that were temporarily suppressed with @ts-expect-error comments.

  • Replaces unsafe .values().next().value! patterns with more type safe helpers getSingleValue<T>() and getFirstValue<T>().
  • Consolidates types for onData$ by reusing ReactExpressionRendererProps['onData$']
  • Created ColumnBuildHints to be used for buildColumns

Checklist

  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@walterra walterra self-assigned this Feb 25, 2026
@walterra walterra added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting v9.4.0 labels Feb 25, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 25, 2026

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!
  • Click to trigger kibana-entity-store-performance-from-pr for this PR!
  • Click to trigger kibana-storybooks-from-pr for this PR!

@walterra walterra force-pushed the lens-ts-fixes branch 2 times, most recently from 3cc49ad to b0a1034 Compare February 26, 2026 09:08
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 26, 2026

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #14 / discover/group10 discover lens vis should show histogram by default
  • [job] [logs] src/platform/test/functional/apps/discover/tabs/config.ts / discover/tabs duplication of a tab should restore the previous app and global states
  • [job] [logs] src/platform/test/functional/apps/discover/tabs2/config.ts / discover/tabs tab filters uses the correct query and filters
  • [job] [logs] src/platform/test/functional/apps/discover/tabs2/config.ts / discover/tabs tab filters uses the correct query and filters
  • [job] [logs] FTR Configs #86 / lens app - group 10 lens logsdb downgrade Scenarios with changing stream type LogsDB downgraded to regular data stream scenarios LogsDB stream with no additional stream/index should visualize correctly ES|QL queries based on a LogsDB stream
  • [job] [logs] FTR Configs #75 / lens app - group 8 lens logsdb smoke testing functions support "after each" hook for "should visualize correctly ES|QL queries based on a LogsDB stream"
  • [job] [logs] FTR Configs #75 / lens app - group 8 lens logsdb smoke testing functions support Scenarios with changing stream type Data-stream upgraded to LogsDB scenarios LogsDB stream with no additional stream/index should visualize correctly ES|QL queries based on a LogsDB stream
  • [job] [logs] FTR Configs #16 / lens serverless - group 1 - subgroup 6 lens logsdb smoke testing functions support "after each" hook for "should visualize correctly ES|QL queries based on a LogsDB stream"
  • [job] [logs] FTR Configs #118 / lens serverless - group 1 - subgroup 6 lens logsdb smoke testing functions support "after each" hook for "should visualize correctly ES|QL queries based on a LogsDB stream"
  • [job] [logs] FTR Configs #16 / lens serverless - group 1 - subgroup 6 lens logsdb smoke testing functions support Scenarios with changing stream type Data-stream upgraded to LogsDB scenarios LogsDB stream with no additional stream/index should visualize correctly ES|QL queries based on a LogsDB stream
  • [job] [logs] FTR Configs #118 / lens serverless - group 1 - subgroup 6 lens logsdb smoke testing functions support Scenarios with changing stream type Data-stream upgraded to LogsDB scenarios LogsDB stream with no additional stream/index should visualize correctly ES|QL queries based on a LogsDB stream
  • [job] [logs] FTR Configs #156 / lens serverless - group 1 - subgroup 8 lens logsdb downgrade Scenarios with changing stream type LogsDB downgraded to regular data stream scenarios LogsDB stream with no additional stream/index should visualize correctly ES|QL queries based on a LogsDB stream
  • [job] [logs] FTR Configs #168 / lens serverless - group 1 - subgroup 8 lens logsdb downgrade Scenarios with changing stream type LogsDB downgraded to regular data stream scenarios LogsDB stream with no additional stream/index should visualize correctly ES|QL queries based on a LogsDB stream

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [6b32bd7]

History

cc @walterra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Lens] TypeScript improvements

2 participants