[ML] Add checkbox to enable model plot in Advanced job wizard#25468
Conversation
alvarezmelissa87
added
release_note:enhancement
review
:ml
Feature:Anomaly Detection
alvarezmelissa87
requested review from
jgowdyelastic,
peteharverson and
walterra
|
Pinging @elastic/ml-ui |
There was a problem hiding this comment.
Probably worth adding where that dedicated results index is configured. Something like If you enable model plot with this configuration we recommend you select a dedicated results index on the Job Details tab. ?
There was a problem hiding this comment.
Do you mean as a warning callout as well?
There was a problem hiding this comment.
Is it worth displaying some sort of warning in the same callout for the error case. Something like An error occurred validating the configuration for running the job with model plot enabled. Creating model plots can be resource intensive and not recommended where the cardinality of the selected fields is high. You may want to select a dedicated results index on the Job Details tab.
There was a problem hiding this comment.
Good one, @peteharverson! 😄 I'll go back and add this to the other wizards as well in a subsequent PR
There was a problem hiding this comment.
Can you add a comment to say when this function would be used
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
We should probably have a unit test for this component, even though it is fairly simple.
💔 Build Failed |
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Latest changes LGTM
|
retest |
💔 Build Failed |
alvarezmelissa87
force-pushed
the
ml-configure-model-plot-advanced
branch
from
4c16507 to
aefa3e3
Compare
💚 Build Succeeded |
…c#25468) * Move cardinality success check to utils * enableModelPlot checkbox base added * Run cardinality check on add/update fields * Handle changes made via json * only run cardinality check if model plot enabled * Handle model plot enabled via EditJSON tab * show message on cardinality check error * multi-metric + pop: show message on cardinality check error * add test for callout component * Fix flexitem overflow in IE11
#25831) * Move cardinality success check to utils * enableModelPlot checkbox base added * Run cardinality check on add/update fields * Handle changes made via json * only run cardinality check if model plot enabled * Handle model plot enabled via EditJSON tab * show message on cardinality check error * multi-metric + pop: show message on cardinality check error * add test for callout component * Fix flexitem overflow in IE11
4 participants
Summary
Related issue: #18164
Follow up to: #24914
Adds an
Enable model plotcheckbox in theAnalysis Configurationtab in theAdvancedjob creation wizard. Creating a job with this checked sets"model_plot_config":{"enabled":true}.for that job.Flow:
Enable model plotis checked cardinality check is run. Callout is shown when cardinality is greater than the threshold (100).-- Changes made in
Detectorsarea or fromAdd detectormodal.currentConfigsand if changes occur via theEdit JSONtab, we update the ui and run cardinality again ifenableModelPlotis set to true and detectors have been updated.Use dedicated indexis NOT automatically checked when cardinality returns a warning. This option is in a separate tab and, therefore, may not be seen by the user so we don't change it.MultiMetric+Populationwizards by still showing callout with warning message.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorialsFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately