[Agent Builder] Improve dynamic attachments: optional tool params, skill discovery, and tracer utilities#254357
Closed
patrykkopycinski wants to merge 1 commit into
Closed
Conversation
…ill discovery, and tracer utilities - Make `selectTools` parameters optional (skills, filestore, experimentalFeatures) with defaults to support callers that don't need skill/filestore integration - Add mandatory skill discovery step to research agent prompt when skills feature is enabled - Strengthen skill loading instructions in skill prompts to enforce protocol compliance - Add `createTracer` utility and barrel export for OpenTelemetry tracing in agent_builder - Add barrel export for kbn-langchain server tracers - Update kbn-langchain tracers README with structured documentation
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectToolsparameters optional (skills,filestore,experimentalFeatures) with sensible defaults, enabling callers that don't need skill/filestore integration (e.g., deep agent mode) to use the function without providing all dependenciesfilestore.readbefore calling other tools)createTracer,createTracerFactory, andgetAgentBuilderTracerutilities for OpenTelemetry tracing in the agent_builder pluginkbn-langchainserver tracers (APMTracer,TelemetryTracer, LangSmith helpers)kbn-langchaintracers README with structured documentation covering all available tracersTest plan
experimentalFeatures.skillsis enabledselectToolsfunction works when optional parameters are not providedProduction-Readiness Checklist — Agent Skills Ecosystem
Generated against [Epic] Creation of the Agent Skills Ecosystem for Elastic Security.
Narrative role: Observability pillar. Exposes OTEL tracers so we can measure invocation frequency and accept/reject rates — the vision's "if we cannot measure it, we cannot responsibly scale it" requirement.
Must-do before this can ship
createTracer/getAgentBuilderTracerthe only supported path — add an ESLint rule forbidding directAPMTracer/TelemetryTracerimports in Agent Builder pluginstrace_idinto SSE events so the UI "why did it do that" surface can deep-link into the tracekbn-langchainserver barrel — the re-exports land on every AB server bundleFollow-ups (post-merge)
@kbn/evalsREADME (pair with docs(evals): vision alignment — trace-first guidance, JSDoc, and public API documentation #258224)