[9.3] [filters] type meta.value as string or object (#253537)#254294
Merged
kibanamachine merged 1 commit intoelastic:9.3from Feb 20, 2026
Merged
[9.3] [filters] type meta.value as string or object (#253537)#254294kibanamachine merged 1 commit intoelastic:9.3from
kibanamachine merged 1 commit intoelastic:9.3from
Conversation
Fixes elastic#253480 `storedFilterMetaSchema.value` schema is too restrictive and needs to be broadened. This PR broadens `storedFilterMetaSchema.value` to any since `storedFilterMetaSchema.value` is a subset of `FilterMetaParams` and to prevent future issues like this. PR also updates `FilterMeta.value` type to more accurately reflect usage. [mapPhrases](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/data/public/query/filter_manager/lib/mappers/map_phrases.ts#L32) sets value to `PhraseFilterValue[]` ``` export const mapPhrases = (filter: Filter) => { if (!isPhrasesFilter(filter)) { throw filter; } const { type, key, params } = filter.meta; return { type, key, value: params, params, }; }; ``` [mapRange](https://github.com/elastic/kibana/blob/main/src/platform/plugins/shared/data/public/query/filter_manager/lib/mappers/map_range.ts#L54) sets value to `RangeFilterParams` ``` function getParams(filter: RangeFilter) { const isScriptedRange = isScriptedRangeFilter(filter); const key: string = (isScriptedRange ? filter.meta.field : getFirstRangeKey(filter)) || ''; const params: any = isScriptedRange ? get(filter.query, 'script.script.params') : getRangeByKey(filter, key); return { type: FILTERS.RANGE, key, value: params, params }; } export const mapRange = (filter: Filter) => { if (!isMapRangeFilter(filter)) { throw filter; } return getParams(filter); }; ``` --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 64510c0)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation