Skip to content

[6.x] [ML] Updates job type and APM module icon to new designs (#25380) #25425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peteharverson merged 1 commit into from
Nov 9, 2018
Merged

[6.x] [ML] Updates job type and APM module icon to new designs (#25380) #25425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions x-pack/plugins/ml/public/assets/ml_create_advanced_job.svg
View file
Open in desktop

This file was deleted.

10 changes: 0 additions & 10 deletions x-pack/plugins/ml/public/assets/ml_create_multi_metric_job.svg
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions x-pack/plugins/ml/public/assets/ml_create_population_job.svg
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions x-pack/plugins/ml/public/assets/ml_create_single_metric_job.svg
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions x-pack/plugins/ml/public/assets/ml_data_visualizer.svg
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/datavisualizer/datavisualizer_sidebar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ <h2>Create Job</h2>
<div class="euiPanel euiPanel--paddingMedium synopsisPanel">
<div class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<img class="synopsisIcon" src="{{urlBasePath}}/plugins/ml/assets/ml_create_advanced_job.svg" alt="Advanced job">
<icon type="'createAdvancedJob'" size="'xl'" aria-label="Advanced job" class="synopsisIcon" />
</div>
<div class="euiFlexItem synopsisContent">
<h4 class="euiTitle euiTitle--small synopsisTitle">Advanced</h4>
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugins/ml/public/jobs/jobs_list/components/job_filter_bar/job_filter_bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ export class JobFilterBar extends Component {
return (
<EuiFlexItem grow={false}>
<EuiCallOut
iconType="faceSad"
color="danger"
title={`Invalid search: ${error.message}`}
/>
Expand Down
10 changes: 5 additions & 5 deletions x-pack/plugins/ml/public/jobs/new_job/wizard/steps/job_type/job_type.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ <h3 class="euiTitle euiTitle--small">Use a wizard</h3>
<div class="euiPanel euiPanel--paddingMedium synopsisPanel">
<div class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<img class="synopsisIcon" ng-src="{{assetsPath}}/ml_create_single_metric_job.svg" alt="Single metric job">
<icon type="'createSingleMetricJob'" size="'xl'" aria-label="Single metric job" class="synopsisIcon" />
</div>
<div class="euiFlexItem synopsisContent">
<h4 class="euiTitle euiTitle--small synopsisTitle">Single metric</h4>
Expand All @@ -85,7 +85,7 @@ <h4 class="euiTitle euiTitle--small synopsisTitle">Single metric</h4>
<div class="euiPanel euiPanel--paddingMedium synopsisPanel">
<div class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<img class="synopsisIcon" ng-src="{{assetsPath}}/ml_create_multi_metric_job.svg" alt="Multi metric job">
<icon type="'createMultiMetricJob'" size="'xl'" aria-label="Multi metric job" class="synopsisIcon" />
</div>
<div class="euiFlexItem synopsisContent">
<h4 class="euiTitle euiTitle--small synopsisTitle">Multi metric</h4>
Expand All @@ -106,7 +106,7 @@ <h4 class="euiTitle euiTitle--small synopsisTitle">Multi metric</h4>
<div class="euiPanel euiPanel--paddingMedium synopsisPanel">
<div class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<img class="synopsisIcon" ng-src="{{assetsPath}}/ml_create_population_job.svg" alt="Population job">
<icon type="'createPopulationJob'" size="'xl'" aria-label="Population job" class="synopsisIcon" />
</div>
<div class="euiFlexItem synopsisContent">
<h4 class="euiTitle euiTitle--small synopsisTitle">Population</h4>
Expand All @@ -127,7 +127,7 @@ <h4 class="euiTitle euiTitle--small synopsisTitle">Population</h4>
<div class="euiPanel euiPanel--paddingMedium synopsisPanel">
<div class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<img class="synopsisIcon" ng-src="{{assetsPath}}/ml_create_advanced_job.svg" alt="Advanced job">
<icon type="'createAdvancedJob'" size="'xl'" aria-label="Advanced job" class="synopsisIcon" />
</div>
<div class="euiFlexItem synopsisContent">
<h4 class="euiTitle euiTitle--small synopsisTitle">Advanced</h4>
Expand Down Expand Up @@ -165,7 +165,7 @@ <h3 class="euiTitle euiTitle--small">Learn more about your data</h3>
<div class="euiPanel euiPanel--paddingMedium synopsisPanel">
<div class="euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--responsive">
<div class="euiFlexItem euiFlexItem--flexGrowZero">
<img class="synopsisIcon" ng-src="{{assetsPath}}/ml_data_visualizer.svg" alt="Single metric job">
<icon type="'dataVisualizer'" size="'xl'" aria-label="Data Visualizer" class="synopsisIcon" />
</div>
<div class="euiFlexItem synopsisContent">
<h4 class="euiTitle euiTitle--small synopsisTitle">Data Visualizer</h4>
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/ml/public/jobs/new_job/wizard/steps/job_type/job_type_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
* the user to select the type of job they wish to create.
*/

import chrome from 'ui/chrome';
import uiRoutes from 'ui/routes';
import { checkLicenseExpired } from 'plugins/ml/license/check_license';
import { checkCreateJobsPrivilege } from 'plugins/ml/privilege/check_privilege';
Expand Down Expand Up @@ -79,5 +78,4 @@ module.controller('MlNewJobStepJobType',
addItemToRecentlyAccessed('jobs/new_job/datavisualizer', title, url);
};

$scope.assetsPath = `${chrome.getBasePath()}/plugins/ml/assets`;
});
Loading