Skip to content

[Streams] Downsampling flyout fixes#254178

Merged
damian-polewski merged 12 commits intoelastic:mainfrom
damian-polewski:streams/downsampling_flyout_fixes
Feb 23, 2026
Merged

[Streams] Downsampling flyout fixes#254178
damian-polewski merged 12 commits intoelastic:mainfrom
damian-polewski:streams/downsampling_flyout_fixes

Conversation

@damian-polewski
Copy link
Copy Markdown
Contributor

@damian-polewski damian-polewski commented Feb 20, 2026

Closes #252545

Summary

This PR fixes issues with EditIlmPhasesFlyout and EditDslStepsFlyout components listed below:

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@damian-polewski damian-polewski self-assigned this Feb 20, 2026
@damian-polewski damian-polewski requested a review from a team as a code owner February 20, 2026 12:19
@damian-polewski damian-polewski added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project labels Feb 20, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Copy link
Copy Markdown
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes, I found a bug in the Dsl flyout. If a step has errors and I click add another one with the error still present, the save button gets enabled when the new step is added

Screen.Recording.2026-02-20.at.15.31.15.mov

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / Header QueryTabHeader should render the immutable timeline call out providers
  • [job] [logs] Jest Integration Tests #6 / ui settings migrations migrates siem:* configs

Metrics [docs]

✅ unchanged

cc @damian-polewski

Copy link
Copy Markdown
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing all this, lgtm :)

@damian-polewski damian-polewski enabled auto-merge (squash) February 23, 2026 09:27
@damian-polewski damian-polewski enabled auto-merge (squash) February 23, 2026 10:06
@damian-polewski damian-polewski merged commit fd0048e into elastic:main Feb 23, 2026
16 checks passed
@damian-polewski damian-polewski deleted the streams/downsampling_flyout_fixes branch February 23, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Streams] EditIlmPhasesFlyout and EditDslStepsFlyout fixes

4 participants