Skip to content

[9.2] Fix Logs tab performance issues (#253326) #253918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Feb 19, 2026
Merged

[9.2] Fix Logs tab performance issues (#253326) #253918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...solutions/observability/plugins/infra/public/components/asset_details/content/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,21 @@ const TabPanel = ({
}) => {
const { renderedTabsSet, activeTabId } = useTabSwitcherContext();

// The logs tab is a special case because it is not rendered in the DOM until it is clicked due to performance reasons.
if (activeWhen === ContentTabIds.LOGS && activeTabId === activeWhen) {
return <div data-test-subj={makeTabPanelDataTestSubj({ tabId: activeWhen })}>{children}</div>;
}

return renderedTabsSet.current.has(activeWhen) ? (
<div
hidden={activeTabId !== activeWhen}
data-test-subj={`infraAssetDetails${capitalize(activeWhen)}TabContent`}
data-test-subj={makeTabPanelDataTestSubj({ tabId: activeWhen })}
>
{children}
</div>
) : null;
};

function makeTabPanelDataTestSubj({ tabId }: { tabId: ContentTabIds }) {
return `infraAssetDetails${capitalize(tabId)}TabContent`;
}
8 changes: 5 additions & 3 deletions ...ns/observability/plugins/infra/public/components/asset_details/hooks/use_tab_switcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import createContainer from 'constate';
import { useLazyRef } from '../../../hooks/use_lazy_ref';
import type { TabIds } from '../types';
import { ContentTabIds, type TabIds } from '../types';
import { useAssetDetailsUrlState } from './use_asset_details_url_state';

interface TabSwitcherParams {
Expand All @@ -23,8 +23,10 @@ export function useTabSwitcher({ defaultActiveTabId }: TabSwitcherParams) {
const renderedTabsSet = useLazyRef(() => new Set([activeTabId]));

const showTab = (tabId: TabIds, options?: { scrollTo?: string }) => {
// On a tab click, mark the tab content as allowed to be rendered
renderedTabsSet.current.add(tabId);
// On a tab click, mark the tab content as allowed to be rendered except for the logs tab.
if (tabId !== ContentTabIds.LOGS) {
renderedTabsSet.current.add(tabId);
}

setUrlState({
tabId: options?.scrollTo ? `${tabId}#${options?.scrollTo}` : tabId,
Expand Down
14 changes: 8 additions & 6 deletions ...solutions/observability/plugins/infra/public/pages/metrics/hosts/components/tabs/tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,13 @@ export const Tabs = () => {
{...tab}
key={index}
onClick={() => {
renderedTabsSet.current.add(tab.id); // On a tab click, mark the tab content as allowed to be rendered
if (tab.id === selectedTabId) return;

// On a tab click, mark the tab content as allowed to be rendered except for the logs tab.
if (tab.id !== TabIds.LOGS) {
renderedTabsSet.current.add(tab.id);
}

setSelectedTabId(tab.id);
}}
isSelected={tab.id === selectedTabId}
Expand All @@ -71,11 +77,7 @@ export const Tabs = () => {
<MetricsGrid />
</div>
)}
{renderedTabsSet.current.has(TabIds.LOGS) && (
<div hidden={selectedTabId !== TabIds.LOGS}>
<LogsTabContent />
</div>
)}
{selectedTabId === TabIds.LOGS && <LogsTabContent />}
{renderedTabsSet.current.has(TabIds.ALERTS) && (
<div hidden={selectedTabId !== TabIds.ALERTS}>
<AlertsTabContent />
Expand Down
3 changes: 2 additions & 1 deletion ...ty/plugins/infra/test/scout/ui/parallel_tests/inventory/host_asset_details_flyout.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ test.describe(
assetDetailsPage.hostOverviewTab.kpiCpuUsageChart.getByRole('heading', {
name: 'CPU Usage',
})
).toBeVisible();
).toBeVisible({ timeout: EXTENDED_TIMEOUT });
await expect(
assetDetailsPage.hostOverviewTab.kpiNormalizedLoadChart.getByRole('heading', {
name: 'Normalized Load',
Expand Down Expand Up @@ -400,6 +400,7 @@ test.describe(
});

await test.step('return to flyout from asset details page', async () => {
await expect(assetDetailsPage.returnButton).toBeVisible({ timeout: EXTENDED_TIMEOUT });
await assetDetailsPage.returnButton.click();
await expect(
page.getByRole('dialog').getByRole('heading', { name: HOST1_NAME })
Expand Down