Skip to content

[Agent Builder] Attachment inline rendering and UI actions#253913

Merged
chrisbmar merged 10 commits intoelastic:mainfrom
chrisbmar:ab-attachment-inline-rendering-clean
Feb 19, 2026
Merged

[Agent Builder] Attachment inline rendering and UI actions#253913
chrisbmar merged 10 commits intoelastic:mainfrom
chrisbmar:ab-attachment-inline-rendering-clean

Conversation

@chrisbmar
Copy link
Copy Markdown
Contributor

closes https://github.com/elastic/search-team/issues/12939

This PR implements the plumbing for the acceptance criteria below, it does not include any UI.

You can see in the following video that the attachment and UI definition is reaching the chat response:

Screen.Recording.2026-02-16.at.17.46.33.mov

Implement:

  • the ability for solutions to define a custom render function in the attachment UI registry
  • the ability solutions to define UI actions in the attachment UI registry

const {
services: { settings },
} = useKibana();
const isExperimentalFeaturesEnabled = settings?.client.get<boolean>(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not blocking but we should consider pushing this up into agentBuilderServices hook

Copy link
Copy Markdown
Contributor Author

@chrisbmar chrisbmar Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we technically don't even need it considering the agent doesn't have any prompt to emit the custom XML tag... so I could remove it for now? This was basically just a guard in case the agent emitted the custom XML tag for attachment_renderer

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeh we can remove for now.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting forever for CI to pass, so will merge this PR as is once CI is done and in the canvas-mode PR I'll remove this check 🙏🏽

Copy link
Copy Markdown
Contributor

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM

@chrisbmar chrisbmar enabled auto-merge (squash) February 19, 2026 09:45
@chrisbmar chrisbmar self-assigned this Feb 19, 2026
@chrisbmar chrisbmar added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Feb 19, 2026
@chrisbmar chrisbmar disabled auto-merge February 19, 2026 11:37
@chrisbmar chrisbmar enabled auto-merge (squash) February 19, 2026 11:37
@chrisbmar chrisbmar merged commit 6308581 into elastic:main Feb 19, 2026
16 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
agentBuilder 1714 1716 +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/agent-builder-browser 15 17 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
agentBuilder 574.0KB 576.1KB +2.1KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/agent-builder-browser 0 3 +3

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
agentBuilder 87.3KB 87.3KB +45.0B
Unknown metric groups

API count

id before after diff
@kbn/agent-builder-browser 33 37 +4

History

cc @chrisbmar

ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants