[ES|QL] Small refactoring#253899
Merged
stratoula merged 1 commit intoelastic:mainfrom Feb 19, 2026
Merged
Conversation
stratoula
commented
Feb 19, 2026
| canCreateLookupIndex, | ||
| isServerless, | ||
| getKqlSuggestions, | ||
| isResourceBrowserEnabled, |
Contributor
Author
There was a problem hiding this comment.
Renamed it to canSuggestResourceBrowser to follow the same pattern as canCreateLookupIndex
stratoula
commented
Feb 19, 2026
| }); | ||
| useEsqlEditorActionsRegistration(editorActions); | ||
|
|
||
| const isResourceBrowserEnabled = useCallback(async () => { |
Contributor
Author
There was a problem hiding this comment.
Moved it to its own hook
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
|
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
bartoval
approved these changes
Feb 19, 2026
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 19, 2026
## Summary Just a small refactoring now that the resources browser got added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Just a small refactoring now that the resources browser got added