Skip to content

[ES|QL] Small refactoring#253899

Merged
stratoula merged 1 commit intoelastic:mainfrom
stratoula:small-refactoring-esql-editor
Feb 19, 2026
Merged

[ES|QL] Small refactoring#253899
stratoula merged 1 commit intoelastic:mainfrom
stratoula:small-refactoring-esql-editor

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

Summary

Just a small refactoring now that the resources browser got added

canCreateLookupIndex,
isServerless,
getKqlSuggestions,
isResourceBrowserEnabled,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed it to canSuggestResourceBrowser to follow the same pattern as canCreateLookupIndex

});
useEsqlEditorActionsRegistration(editorActions);

const isResourceBrowserEnabled = useCallback(async () => {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved it to its own hook

@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.4.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Feb 19, 2026
@stratoula stratoula changed the title [ES|QL] small refactoring [ES|QL] Small refactoring Feb 19, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #10 / Header QueryTabHeader should render the unauthorized call out with correct icon
  • [job] [logs] Jest Tests #10 / Kibana deprecations - Deprecations table Search bar filters by "critical" status

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
esql 1004 1005 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 781.5KB 781.5KB +7.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 4.6MB 4.6MB +4.0B

@stratoula stratoula marked this pull request as ready for review February 19, 2026 10:10
@stratoula stratoula requested a review from a team as a code owner February 19, 2026 10:10
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula merged commit e96acf9 into elastic:main Feb 19, 2026
30 checks passed
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
## Summary

Just a small refactoring now that the resources browser got added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants