[ES|QL] add consideration for inline cast to cascade experience capture rules#253819
Merged
Conversation
eokoneyo
added
release_note:skip
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Feb 19, 2026
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
Looks great eyo, thanks a lot!
I created this PR eokoneyo#3 to do a small refactor to make this if a bit more readable. Wdyt?
Small improvement for readability
Contributor
Author
I like it... merged it in |
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 19, 2026
…re rules (elastic#253819) Closes elastic#253708 ## Summary This PR; - Extends the `getESQLStatsQueryMeta` unsupported grouping function check to also detect inline casts (`::`) that wrap unsupported functions (e.g., `BUCKET(@timestamp, 1 hour)::string`), which previously bypassed the validation because the top-level node was an `inlineCast` rather than a `function` expression. - Simple column casts (e.g., `clientip::keyword`) and casts wrapping supported functions (e.g., `CATEGORIZE`) remain valid for the cascade experience. - Adds unit tests covering both the invalidation and boundary cases. ### Details Previously, `getESQLStatsQueryMeta` only checked for bare `isFunctionExpression` nodes when deciding if a STATS BY group field uses an unsupported function. An inline cast like `BUCKET(@timestamp, 1 hour)::string` produces an `inlineCast` AST node at the top level, so the existing check didn't catch it. This meant queries with cast-wrapped unsupported functions could incorrectly qualify for the cascade layout. ### Checklist <!-- Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials --> - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios <!-- - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --> --------- Co-authored-by: Stratoula <efstratia.kalafateli@elastic.co>
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253708
Summary
This PR;
getESQLStatsQueryMetaunsupported grouping function check to also detect inline casts (::) that wrap unsupported functions (e.g.,BUCKET(@timestamp, 1 hour)::string), which previously bypassed the validation because the top-level node was aninlineCastrather than afunctionexpression.clientip::keyword) and casts wrapping supported functions (e.g.,CATEGORIZE) remain valid for the cascade experience.Details
Previously,
getESQLStatsQueryMetaonly checked for bareisFunctionExpressionnodes when deciding if a STATS BY group field uses an unsupported function. An inline cast likeBUCKET(@timestamp, 1 hour)::stringproduces aninlineCastAST node at the top level, so the existing check didn't catch it. This meant queries with cast-wrapped unsupported functions could incorrectly qualify for the cascade layout.Checklist