Skip to content

[ES|QL] Fixes the rule creation problem#253754

Merged
stratoula merged 5 commits intoelastic:mainfrom
stratoula:fix-rule-esql
Feb 19, 2026
Merged

[ES|QL] Fixes the rule creation problem#253754
stratoula merged 5 commits intoelastic:mainfrom
stratoula:fix-rule-esql

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Feb 18, 2026 •
edited
Loading

Summary

The refactoring caused the ES|QL rule creation to crash. This is fixing it.

image

@stratoula stratoula added v9.4.0 backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels Feb 18, 2026
@stratoula stratoula marked this pull request as ready for review February 18, 2026 16:17
@stratoula stratoula requested a review from a team as a code owner February 18, 2026 16:17
@stratoula stratoula enabled auto-merge (squash) February 18, 2026 16:18
@stratoula
Copy link
Copy Markdown
Contributor Author

stratoula commented Feb 18, 2026

@elasticmachine merge upstream

vitaliidm
vitaliidm reviewed Feb 18, 2026
View reviewed changes
Comment thread ...olution/public/detection_engine/rule_creation/components/esql_query_edit/esql_query_edit.tsx
[required, path, fieldsToValidateOnChange, queryClient]
);

return (
Copy link
Copy Markdown
Contributor

@vitaliidm vitaliidm Feb 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a case when page crashes with slightly different issue.

When I open create form -> it works and displayed.
When I close this form and go to edit form
It crashes with this error

TypeError: Cannot read properties of undefined (reading 'subscribe')
    at http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:254543:29
    at commitHookEffectListMount (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:70647:26)
    at commitLayoutEffectOnFiber (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:70765:17)
    at commitLayoutMountEffects_complete (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:72185:9)
    at commitLayoutEffects_begin (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:72171:7)
    at commitLayoutEffects (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:72109:3)
    at commitRootImpl (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:74320:5)
    at commitRoot (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:74179:5)
    at performSyncWorkOnRoot (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:73614:3)
    at flushSyncCallbacks (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:59544:22)
    

The above error occurred in ErrorBoundary:


    at ErrorBoundary (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:376600:7)
    at DragDropContext (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:384122:23)
    at DragDropContextWrapperComponent (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.34.js:3078:3)
    at http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.45.js:5356:3
    at div
    at http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:201415:66
    at HomePageComponent (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.34.js:830:3)
    at FilesContext (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/cases/1.0.0/cases.plugin.js:25042:3)
    at QueryClientProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:391254:3)
    at CasesProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/cases/1.0.0/cases.plugin.js:24870:3)
    at Suspense
    at CasesProviderLazyWrapper (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/cases/1.0.0/cases.plugin.js:31619:3)
    at CasesProviderLazyWrapperWithRegistry (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/cases/1.0.0/cases.plugin.js:31669:5)
    at Route (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:464952:29)
    at Route (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:274618:3)
    at Switch (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:465154:29)
    at Routes (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:274927:3)
    at http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.41.js:334:3
    at RenderedRoute (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:468203:5)
    at Routes (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:468937:5)
    at Router (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:468871:15)
    at CompatRouter (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:467525:5)
    at Router (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:464571:30)
    at Router (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:274869:3)
    at ManageRoutesSpyComponent (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.34.js:5301:3)
    at PageRouterComponent (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.34.js:1033:3)
    at DiscoverInTimelineContextProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.34.js:2632:79)
    at http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.34.js:5008:3
    at CellActionsProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.12.js:6021:3)
    at QueryClientProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:391254:3)
    at http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.9.js:1622:3
    at NavigationProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.plugin.js:1502:3)
    at ManageUserInfo (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.41.js:140:3)
    at UserPrivilegesProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.29.js:12645:3)
    at http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.18.js:11276:3
    at Le (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:484600:17336)
    at KibanaStyledComponentsThemeProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:2805:3)
    at Provider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:385594:20)
    at ManageGlobalToaster (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.13.js:771:3)
    at ErrorBoundaryInternal (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:266512:5)
    at KibanaErrorBoundary (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:266587:79)
    at KibanaErrorBoundaryProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:266094:3)
    at SidebarServiceProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:276638:3)
    at EuiContext (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:223079:24)
    at IntlProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:10196:47)
    at I18nProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:10712:3)
    at I18nContext (http://localhost:5661/XXXXXXXXXXXX/bundles/core/core.entry.js:12464:9)
    at KibanaErrorBoundaryProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:266094:3)
    at EuiFlyoutManagerContainer (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:286115:24)
    at EuiFlyoutManager (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:286099:23)
    at EuiComponentDefaultsProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:226540:36)
    at CurrentEuiBreakpointProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:175236:23)
    at ThemeProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:201478:50)
    at EuiEmotionThemeProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:205275:23)
    at EuiThemeMemoizedStylesProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:205325:23)
    at EuiThemeProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:204498:22)
    at EuiSystemDefaultsProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:356897:23)
    at EuiCacheProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:356834:20)
    at EuiProviderNestedCheck (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:357030:23)
    at EuiProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-npm/kbn-ui-shared-deps-npm.dll.js:356678:25)
    at KibanaEuiProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:273940:3)
    at KibanaRootContextProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:273694:3)
    at KibanaRenderContextProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/kbn-ui-shared-deps-src/kbn-ui-shared-deps-src.js:274212:3)
    at StartAppComponent (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.34.js:131:3)
    at CloudContextProvider (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/cloud/1.0.0/cloud.plugin.js:174:7)
    at Provider (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/kibanaReact/1.0.0/kibanaReact.plugin.js:428:15)
    at SecurityAppComponent (http://localhost:5661/XXXXXXXXXXXX/bundles/plugin/securitySolution/1.0.0/securitySolution.chunk.34.js:275:3)
Screen.Recording.2026-02-18.at.17.33.42.mov

Copy link
Copy Markdown
Contributor Author

@stratoula stratoula Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very weird as this is also using the same component and the context provider should wrap it. I brought it closer to the component 748a517 and this seems to fix it

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2026

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.1MB 11.1MB +26.0B

History

vitaliidm
vitaliidm approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stratoula stratoula merged commit 2214d95 into elastic:main Feb 19, 2026
16 checks passed
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
@stratoula @ersin-erdal
[ES|QL] Fixes the rule creation problem (elastic#253754)
b1a1169 
## Summary

The refactoring caused the ES|QL rule creation to crash. This is fixing
it.

<img width="819" height="289" alt="image"
src="https://github.com/user-attachments/assets/d28add3d-763d-4cd4-b1e4-3e7c5b6cbbb2"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitaliidm vitaliidm vitaliidm approved these changes

@nkhristinin nkhristinin Awaiting requested review from nkhristinin nkhristinin is a code owner automatically assigned from elastic/security-detection-engine

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stratoula @elasticmachine @vitaliidm