Skip to content

[ES|QL] Fixes the focus flickering at the badge#253736

Merged
stratoula merged 5 commits intoelastic:mainfrom
stratoula:fix-browser-flickering
Feb 19, 2026
Merged

[ES|QL] Fixes the focus flickering at the badge#253736
stratoula merged 5 commits intoelastic:mainfrom
stratoula:fix-browser-flickering

Conversation

@stratoula
Copy link
Copy Markdown
Contributor

@stratoula stratoula commented Feb 18, 2026 •
edited
Loading

Summary

This is an improvement on how the badge resource browser functions with focus. At main when you click the badge there is a bad flickering, the focus goes to the editor and then to the popover which makes the transition bad.

This PR ensures that the transition will be smooth

meow

@stratoula stratoula added v9.4.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Feb 18, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 18, 2026 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 780.5KB 780.7KB +204.0B

History

@stratoula stratoula marked this pull request as ready for review February 19, 2026 06:34
@stratoula stratoula requested review from a team as code owners February 19, 2026 06:34
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2026

Pinging @elastic/kibana-esql (Team:ESQL)

bartoval
bartoval approved these changes Feb 19, 2026
View reviewed changes
Comment thread ...latform/packages/private/kbn-esql-editor/src/resource_browser/use_resource_browser_badge.tsx
@ElenaStoeva ElenaStoeva self-requested a review February 19, 2026 10:09
ElenaStoeva
ElenaStoeva approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Having the suggestions open after closing the browser was very annoying indeed - looks much better now.
Code changes lgtm.

@stratoula stratoula merged commit 60d6320 into elastic:main Feb 19, 2026
18 checks passed
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
@stratoula @ersin-erdal
[ES|QL] Fixes the focus flickering at the badge (elastic#253736)
913e68f 
## Summary

This is an improvement on how the badge resource browser functions with
focus. At main when you click the badge there is a bad flickering, the
focus goes to the editor and then to the popover which makes the
transition bad.

This PR ensures that the transition will be smooth


![meow](https://github.com/user-attachments/assets/83c22cda-d46b-42c5-b9ae-6ee57decfb27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

@bartoval bartoval bartoval approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stratoula @elasticmachine @ElenaStoeva @bartoval