[Security Solution][Attacks] Flyout: improving assignees functionality#253729
Conversation
agusruidiazgd
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
| }); | ||
|
|
||
| const showAssignees = hasPermission && isPlatinumPlus; | ||
| const uids = useMemo(() => new Set(assignees), [assignees]); |
There was a problem hiding this comment.
This is a great way to get rid of duplicates! 😄
I can see that useBulkGetUserProfiles accepts an array of string, but we are passing a Set at the moment.
Maybe we could wrap the set with a Array.from to make it consistent with what useBulkGetUserProfiles is expecting?
Array.from(new Set(assignees))What do you think?
There was a problem hiding this comment.
Hey @NicholasPeretti thanks for your review. I've double check my implementation but it seems that useBulkGetUserProfiles is expecting a Set<string> so the Array.from is giving me type issues. Here is the code
There was a problem hiding this comment.
Oh my bad... maybe I checked the wrong function or maybe I was on a different branch 😅
Thanks for addressing my comment
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
4 participants
Summary
Address this comment implementing a improvement to the assignees functionality on the Attack Details Flyour header