Skip to content

[9.2] Fixed EsLint violations of @elastic/eui/badge-accessibility-rules rule in Kibana code. (#251665) #253698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexwizp merged 1 commit into from
Feb 19, 2026
Merged

[9.2] Fixed EsLint violations of @elastic/eui/badge-accessibility-rules rule in Kibana code. (#251665) #253698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...platform/plugins/shared/dashboard/public/dashboard_top_nav/internal_dashboard_top_nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,8 +285,6 @@ export function InternalDashboardTopNav({
...getManagedContentBadge(dashboardManagedBadge.getBadgeAriaLabel()),
onClick: () => setIsPopoverOpen(!isPopoverOpen),
onClickAriaLabel: dashboardManagedBadge.getBadgeAriaLabel(),
iconOnClick: () => setIsPopoverOpen(!isPopoverOpen),
iconOnClickAriaLabel: dashboardManagedBadge.getBadgeAriaLabel(),
} as TopNavMenuBadgeProps;

allBadges.push({
Expand Down
2 changes: 0 additions & 2 deletions ...dit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions ...ment/public/components/edit_index_pattern/indexed_fields_table/components/table/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,6 @@ const getConflictBtn = (
color="warning"
iconType="warning"
onClick={onClick}
iconOnClick={onClick}
iconOnClickAriaLabel={conflictDetailIconAria}
onClickAriaLabel={conflictDetailIconAria}
>
{conflictType}
Expand Down
25 changes: 0 additions & 25 deletions ...lugins/private/monitoring/public/components/setup_mode/__snapshots__/tooltip.test.js.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 5 additions & 30 deletions x-pack/platform/plugins/private/monitoring/public/components/setup_mode/tooltip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,7 @@ export function SetupModeTooltip({ setupModeData, badgeClickLink, productName })
defaultMessage: `We detected usage of this product. Click to start monitoring.`,
})}
>
<EuiBadge
color="warning"
iconType="flag"
href={badgeClickLink}
onClickAriaLabel={detectedText}
>
<EuiBadge color="warning" iconType="flag" href={badgeClickLink}>
{detectedText}
</EuiBadge>
</EuiToolTip>
Expand All @@ -68,12 +63,7 @@ export function SetupModeTooltip({ setupModeData, badgeClickLink, productName })
},
})}
>
<EuiBadge
color="hollow"
iconType="flag"
href={badgeClickLink}
onClickAriaLabel={noMonitoringText}
>
<EuiBadge color="hollow" iconType="flag" href={badgeClickLink}>
{noMonitoringText}
</EuiBadge>
</EuiToolTip>
Expand All @@ -96,12 +86,7 @@ export function SetupModeTooltip({ setupModeData, badgeClickLink, productName })
},
})}
>
<EuiBadge
color="danger"
iconType="flag"
href={badgeClickLink}
onClickAriaLabel={internalCollection}
>
<EuiBadge color="danger" iconType="flag" href={badgeClickLink}>
{internalCollection}
</EuiBadge>
</EuiToolTip>
Expand All @@ -120,12 +105,7 @@ export function SetupModeTooltip({ setupModeData, badgeClickLink, productName })
},
})}
>
<EuiBadge
color="warning"
iconType="flag"
href={badgeClickLink}
onClickAriaLabel={internalAndMB}
>
<EuiBadge color="warning" iconType="flag" href={badgeClickLink}>
{internalAndMB}
</EuiBadge>
</EuiToolTip>
Expand All @@ -144,12 +124,7 @@ export function SetupModeTooltip({ setupModeData, badgeClickLink, productName })
},
})}
>
<EuiBadge
color="success"
iconType="flag"
href={badgeClickLink}
onClickAriaLabel={metricbeatCollection}
>
<EuiBadge color="success" iconType="flag" href={badgeClickLink}>
{metricbeatCollection}
</EuiBadge>
</EuiToolTip>
Expand Down
3 changes: 0 additions & 3 deletions ...ugins/shared/aiops/public/components/log_rate_analysis/log_rate_analysis_info_popover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ export const LogRateAnalysisInfoPopoverButton: FC<{
iconType="question"
iconSide="right"
color="hollow"
// Defining both iconOnClick and onClick so the mouse cursor changes for cases.
iconOnClick={onClick}
iconOnClickAriaLabel='Click to open "Log rate analysis info" popover'
onClick={onClick}
onClickAriaLabel='Click to open "Log rate analysis info" popover'
data-test-subj="aiopsLogRateAnalysisInfoPopoverButton"
Expand Down
2 changes: 0 additions & 2 deletions ...hared/content_connectors/public/components/shared/react_router_helpers/eui_components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,6 @@ export const EuiBadgeTo: React.FC<ReactRouterEuiBadgeProps> = ({

const badgeProps: EuiBadgeProps = {
...rest,
iconOnClick: routerProps.onClick,
iconOnClickAriaLabel: label,
onClick: routerProps.onClick,
onClickAriaLabel: label,
};
Expand Down
2 changes: 0 additions & 2 deletions ...ic/applications/fleet/sections/agents/agent_list_page/components/agent_activity_badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ export const AgentActivityBadge: React.FunctionComponent<{
onClick={onClick}
onClickAriaLabel="Open the Agent activity flyout"
iconType="warning"
iconOnClick={onClick}
iconOnClickAriaLabel="Open the Agent activity flyout"
data-test-subj="agentActivityBadge"
>
<FormattedMessage
Expand Down
2 changes: 0 additions & 2 deletions x-pack/platform/plugins/shared/saved_objects_tagging/public/components/base/tag_badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ export const TagBadge: <T extends TagAttributes>(props: TagBadgeProps<T>) => Rea
tagName: tag.name,
},
}),
iconOnClick: () => undefined,
iconOnClickAriaLabel: '',
}
: {};

Expand Down
11 changes: 0 additions & 11 deletions ..._app/public/components/stream_detail_significant_events_view/significant_events_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,17 +90,6 @@ export function SignificantEventsTable({
setSelectedFeature(featuresByName[query.feature.name]);
}
}}
iconOnClick={() => {
if (query.feature?.name) {
setSelectedFeature(featuresByName[query.feature.name]);
}
}}
iconOnClickAriaLabel={i18n.translate(
'xpack.streams.significantEventsTable.featureDetailsFlyoutAriaLabel',
{
defaultMessage: 'Open feature details',
}
)}
>
{query.feature?.name ?? '--'}
</EuiBadge>
Expand Down
12 changes: 3 additions & 9 deletions ...actions_ui/public/application/sections/rule_details/components/rule_status_panel.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,9 +188,7 @@ describe('rule status panel', () => {
bulkDisableRules={bulkDisableRules}
/>
);
const actionsElem = wrapper
.find('[data-test-subj="statusDropdown"] .euiBadge__childButton')
.first();
const actionsElem = wrapper.find('[data-test-subj="statusDropdown"] button').first();
actionsElem.simulate('click');

await act(async () => {
Expand Down Expand Up @@ -220,9 +218,7 @@ describe('rule status panel', () => {
requestRefresh={requestRefresh}
/>
);
const actionsElem = wrapper
.find('[data-test-subj="statusDropdown"] .euiBadge__childButton')
.first();
const actionsElem = wrapper.find('[data-test-subj="statusDropdown"] button').first();
actionsElem.simulate('click');

await act(async () => {
Expand Down Expand Up @@ -254,9 +250,7 @@ describe('rule status panel', () => {
bulkEnableRules={bulkEnableRules}
/>
);
const actionsElem = wrapper
.find('[data-test-subj="statusDropdown"] .euiBadge__childButton')
.first();
const actionsElem = wrapper.find('[data-test-subj="statusDropdown"] button').first();
actionsElem.simulate('click');

await act(async () => {
Expand Down
2 changes: 0 additions & 2 deletions ...ers_actions_ui/public/application/sections/rules_list/components/rule_status_dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,9 +207,7 @@ export const RuleStatusDropdown: React.FunctionComponent<ComponentOpts> = ({
iconSide="right"
iconType={!isUpdating && isEditable ? 'arrowDown' : undefined}
onClick={onClickBadge}
iconOnClick={onClickBadge}
onClickAriaLabel={OPEN_MENU_ARIA_LABEL}
iconOnClickAriaLabel={OPEN_MENU_ARIA_LABEL}
isDisabled={isUpdating}
>
{badgeMessage}
Expand Down
Loading
Loading