Skip to content

[Automatic Migrations] Include a key property for better identification of migration options.#253676

Merged
angorayc merged 4 commits intoelastic:mainfrom
angorayc:issue-244525
Feb 19, 2026
Merged

[Automatic Migrations] Include a key property for better identification of migration options.#253676
angorayc merged 4 commits intoelastic:mainfrom
angorayc:issue-244525

Conversation

@angorayc
Copy link
Copy Markdown
Contributor

@angorayc angorayc commented Feb 18, 2026 •
edited by kibanamachine
Loading

Summary

#244525

Fixes EuiComboBox migration selection when multiple migrations share the same name by ensuring options have a unique key (id) and by deriving selectedOptions from the existing option instance matched by migration id.

Steps to reproduce

  1. Create a few SIEM migrations with the same name
  2. Visit the migrations page
  3. Select one of the migrations

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

@angorayc angorayc requested a review from a team as a code owner February 18, 2026 10:34
@angorayc angorayc added bug Fixes for quality problems that affect the customer experience Team:Threat Hunting Security Solution Threat Hunting Team v9.4.0 v9.3.1 labels Feb 18, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 18, 2026

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@angorayc angorayc requested a review from logeekal February 18, 2026 10:36
@angorayc angorayc added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Feb 18, 2026
logeekal
logeekal approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@logeekal logeekal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @angorayc for fixing it. 🚀

@angorayc angorayc enabled auto-merge (squash) February 19, 2026 10:46
@angorayc angorayc merged commit 7a7ed9b into elastic:main Feb 19, 2026
16 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 19, 2026

Starting backport for target branches: 9.3

https://github.com/elastic/kibana/actions/runs/22179570311

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 11.1MB 11.1MB +65.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 19, 2026
@angorayc
[Automatic Migrations] Include a key property for better identifica…
2773e1e 
…tion of migration options. (elastic#253676)

## Summary

elastic#244525

Fixes EuiComboBox migration selection when multiple migrations share the
same name by ensuring options have a unique key (id) and by deriving
selectedOptions from the existing option instance matched by migration
id.

### Steps to reproduce

1. Create a few SIEM migrations with the same name
2. Visit the migrations page
3. Select one of the migrations

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 7a7ed9b)
@kibanamachine kibanamachine mentioned this pull request Feb 19, 2026
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 19, 2026

💚 All backports created successfully

Status Branch Result
✅ 9.3

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 19, 2026
@kibanamachine @angorayc
[9.3] [Automatic Migrations] Include a key property for better iden…
879d832 
…tification of migration options. (#253676) (#253945)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[Automatic Migrations] Include a `key` property for better
identification of migration options.
(#253676)](#253676)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"6295984+angorayc@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-02-19T11:17:24Z","message":"[Automatic
Migrations] Include a `key` property for better identification of
migration options. (#253676)\n\n##
Summary\n\nhttps://github.com//issues/244525\n\nFixes
EuiComboBox migration selection when multiple migrations share the\nsame
name by ensuring options have a unique key (id) and by
deriving\nselectedOptions from the existing option instance matched by
migration\nid.\n\n### Steps to reproduce\n\n1. Create a few SIEM
migrations with the same name\n2. Visit the migrations page\n3. Select
one of the migrations\n\n### Checklist\n\nCheck the PR satisfies
following conditions. \n\nReviewers should verify this PR satisfies this
list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"7a7ed9be51fa94c4ff732655c54a7a1c89bf3fcb","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","backport:version","v9.4.0","v9.3.1"],"title":"[Automatic
Migrations] Include a `key` property for better identification of
migration
options.","number":253676,"url":"https://github.com/elastic/kibana/pull/253676","mergeCommit":{"message":"[Automatic
Migrations] Include a `key` property for better identification of
migration options. (#253676)\n\n##
Summary\n\nhttps://github.com//issues/244525\n\nFixes
EuiComboBox migration selection when multiple migrations share the\nsame
name by ensuring options have a unique key (id) and by
deriving\nselectedOptions from the existing option instance matched by
migration\nid.\n\n### Steps to reproduce\n\n1. Create a few SIEM
migrations with the same name\n2. Visit the migrations page\n3. Select
one of the migrations\n\n### Checklist\n\nCheck the PR satisfies
following conditions. \n\nReviewers should verify this PR satisfies this
list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"7a7ed9be51fa94c4ff732655c54a7a1c89bf3fcb"}},"sourceBranch":"main","suggestedTargetBranches":["9.3"],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/253676","number":253676,"mergeCommit":{"message":"[Automatic
Migrations] Include a `key` property for better identification of
migration options. (#253676)\n\n##
Summary\n\nhttps://github.com//issues/244525\n\nFixes
EuiComboBox migration selection when multiple migrations share the\nsame
name by ensuring options have a unique key (id) and by
deriving\nselectedOptions from the existing option instance matched by
migration\nid.\n\n### Steps to reproduce\n\n1. Create a few SIEM
migrations with the same name\n2. Visit the migrations page\n3. Select
one of the migrations\n\n### Checklist\n\nCheck the PR satisfies
following conditions. \n\nReviewers should verify this PR satisfies this
list as well.\n\n- [x] [Unit or
functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere
updated or added to match the most common
scenarios","sha":"7a7ed9be51fa94c4ff732655c54a7a1c89bf3fcb"}},{"branch":"9.3","label":"v9.3.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <6295984+angorayc@users.noreply.github.com>
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
@angorayc @ersin-erdal
[Automatic Migrations] Include a key property for better identifica…
921bf6c 
…tion of migration options. (elastic#253676)

## Summary

elastic#244525

Fixes EuiComboBox migration selection when multiple migrations share the
same name by ensuring options have a unique key (id) and by deriving
selectedOptions from the existing option instance matched by migration
id.

### Steps to reproduce

1. Create a few SIEM migrations with the same name
2. Visit the migrations page
3. Select one of the migrations

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@logeekal logeekal logeekal approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v9.3.1 v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@angorayc @elasticmachine @kibanamachine @logeekal