[Streams] Add suggested name#253652
Merged
SoniaSanzV merged 7 commits intoelastic:mainfrom Feb 18, 2026
Merged
Conversation
SoniaSanzV
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
Merged
damian-polewski
requested changes
Feb 18, 2026
| await waitFor(() => expect(onSave).toHaveBeenCalledWith('new-policy')); | ||
| }); | ||
|
|
||
| it('pre-populates the policy name field with the original policy name', () => { |
Contributor
There was a problem hiding this comment.
nit: It's not really the original policy name but original + "-2" so we can change it for clarity.
Suggested change
| it('pre-populates the policy name field with the original policy name', () => { | |
| it('pre-populates with the default copy name', () => { |
gbamparop
approved these changes
Feb 18, 2026
Contributor
gbamparop
left a comment
gbamparop
left a comment
There was a problem hiding this comment.
Code only review for x-pack/platform/plugins/shared/streams_app/public/components/data_management/stream_detail_lifecycle/hooks/use_ilm_lifecycle_summary.tsx LGTM
damian-polewski
approved these changes
Feb 18, 2026
Contributor
damian-polewski
left a comment
damian-polewski
left a comment
There was a problem hiding this comment.
LGTM! Added one small non-blocking nit.
Comment on lines
+46
to
+56
| // If the shortest candidate is already too long, any other single-digit suffix will be too. | ||
| if (getPolicyNameIsBeyondMaxBytes(`${originalPolicyName}-2`)) { | ||
| return ''; | ||
| } | ||
|
|
||
| for (let i = 2; i <= 9; i++) { | ||
| const candidate = `${originalPolicyName}-${i}`; | ||
| if (!existing.has(candidate) && !getPolicyNameIsBeyondMaxBytes(candidate)) { | ||
| return candidate; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need to check both before and inside the loop?
Contributor
Author
There was a problem hiding this comment.
I don't think that's needed. {name}-2 and {name}-9 (max number) would have the same UTF‑8 byte length, so checking inside the loop is redundan
Contributor
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]
History
cc @SoniaSanzV |
SoniaSanzV
deleted the
downsampling/create_new_policy_modal_suggested_name
branch
chrisbmar
pushed a commit
to chrisbmar/kibana
that referenced
this pull request
Feb 19, 2026
## Summary
Small change in the `CreatePolicyModal`. The modal now needs a new prop
with the name of the original policy from which is being copied, in
order of pre-populate a name that would help the user. It tries to
suggest a name by adding a small number to the end of the original name:
first `{original-policy-name}-2`, if that already exists then
`{original-policy-name}-3`, then `{original-policy-name}-4`, up to
`{original-policy-name}-9`; if all of those already exist, it leaves the
field empty so the user can choose a name.
### How to test
View and test the component in Storybook:
```bash
yarn storybook streams_app
```
It can also be tested in the Streams UI:
* Create a policy with some downsampling steps
* Assign it to a couple of streams, remove a downsampling step from one
of them.
* Click save as new
* Verify the text field is filled with a suggested name
https://github.com/user-attachments/assets/aa1bb08d-b311-48c7-bd49-6bdfcefb676b
ersin-erdal
pushed a commit
to ersin-erdal/kibana
that referenced
this pull request
Feb 19, 2026
## Summary
Small change in the `CreatePolicyModal`. The modal now needs a new prop
with the name of the original policy from which is being copied, in
order of pre-populate a name that would help the user. It tries to
suggest a name by adding a small number to the end of the original name:
first `{original-policy-name}-2`, if that already exists then
`{original-policy-name}-3`, then `{original-policy-name}-4`, up to
`{original-policy-name}-9`; if all of those already exist, it leaves the
field empty so the user can choose a name.
### How to test
View and test the component in Storybook:
```bash
yarn storybook streams_app
```
It can also be tested in the Streams UI:
* Create a policy with some downsampling steps
* Assign it to a couple of streams, remove a downsampling step from one
of them.
* Click save as new
* Verify the text field is filled with a suggested name
https://github.com/user-attachments/assets/aa1bb08d-b311-48c7-bd49-6bdfcefb676b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small change in the
CreatePolicyModal. The modal now needs a new prop with the name of the original policy from which is being copied, in order of pre-populate a name that would help the user. It tries to suggest a name by adding a small number to the end of the original name: first{original-policy-name}-2, if that already exists then{original-policy-name}-3, then{original-policy-name}-4, up to{original-policy-name}-9; if all of those already exist, it leaves the field empty so the user can choose a name.How to test
View and test the component in Storybook:
It can also be tested in the Streams UI:
Screen.Recording.2026-02-18.at.11.57.18.mov