Skip to content

fix: add PR guidance when baseline snapshot is missing#253555

Merged
hammad-nasir-elastic merged 3 commits intoelastic:mainfrom
hammad-nasir-elastic:fix/saved-objects-baseline-comment
Feb 20, 2026
Merged

fix: add PR guidance when baseline snapshot is missing#253555
hammad-nasir-elastic merged 3 commits intoelastic:mainfrom
hammad-nasir-elastic:fix/saved-objects-baseline-comment

Conversation

@hammad-nasir-elastic
Copy link
Copy Markdown
Contributor

@hammad-nasir-elastic hammad-nasir-elastic commented Feb 17, 2026 •
edited
Loading

resolves elastic/kibana-team#2704

Summary

  • Improve the Saved Objects baseline-missing guidance by surfacing remediation directly in the failing CI step logs.
  • Keep the check behavior unchanged: the step still fails when no baseline snapshot is found.
  • Remove PR-comment posting so guidance is communicated in-step without adding PR thread noise.

Problem

  • The Saved Objects check can fail when no baseline snapshot is found after traversing merge-base ancestors.
  • Contributors needed clearer, immediate guidance on how to recover from that failure.
  • Posting a dedicated PR comment for this case adds extra PR noise and was not necessary.

Solution

  • Keep the baseline-missing message in the step error logs with a direct remediation instruction.
  • Remove the explicit PR comment-posting path for this failure scenario.
  • Preserve existing failure semantics while making the guidance easier to consume in CI logs.

@hammad-nasir-elastic @cursoragent
fix: add PR guidance when baseline snapshot is missing
5b48396 
Post a contextual PR comment when the saved objects baseline snapshot cannot be found after ancestor lookup, so contributors know to rebase onto a green main commit.

Closes elastic/kibana-team#2704

Co-authored-by: Cursor <cursoragent@cursor.com>
@hammad-nasir-elastic hammad-nasir-elastic requested a review from a team as a code owner February 17, 2026 19:14
@hammad-nasir-elastic hammad-nasir-elastic added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Feb 17, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 17, 2026

Pinging @elastic/kibana-core (Team:Core)

1 similar comment
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 17, 2026

Pinging @elastic/kibana-core (Team:Core)

@hammad-nasir-elastic hammad-nasir-elastic self-assigned this Feb 17, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 17, 2026 •
edited
Loading

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #105 / console app console autocomplete feature Autocomplete shouldnt trigger within a multiline block comment

History

cc @hammad-nasir-elastic

Ikuni17
Ikuni17 reviewed Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ikuni17 Ikuni17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example of this running?

Comment thread .buildkite/scripts/steps/check_saved_objects.sh Outdated
Comment thread .buildkite/scripts/steps/check_saved_objects.sh Outdated
hammad-nasir-elastic and others added 2 commits February 18, 2026 10:27
@hammad-nasir-elastic @cursoragent
fix: keep baseline guidance in saved objects step logs only
6cd236a 
Remove PR comment posting for baseline snapshot misses and keep remediation guidance directly in the failing step log output.

Closes elastic/kibana-team#2704

Co-authored-by: Cursor <cursoragent@cursor.com>
@hammad-nasir-elastic
Merge branch 'main' into fix/saved-objects-baseline-comment
6c5607b
TinaHeiligers
TinaHeiligers approved these changes Feb 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@TinaHeiligers TinaHeiligers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hammad-nasir-elastic hammad-nasir-elastic merged commit a392440 into elastic:main Feb 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TinaHeiligers TinaHeiligers TinaHeiligers approved these changes

@Ikuni17 Ikuni17 Ikuni17 approved these changes

Assignees

@hammad-nasir-elastic hammad-nasir-elastic

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hammad-nasir-elastic @elasticmachine @TinaHeiligers @Ikuni17 @kibanamachine