Skip to content

[APM] Fix missing transaction message #25353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorenlouv merged 1 commit into from
Nov 8, 2018
Merged

[APM] Fix missing transaction message #25353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions x-pack/plugins/apm/public/store/reactReduxRequest/transactionDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,8 @@ import { IUrlParams } from '../urlParams';
import { createInitialDataSelector } from './helpers';

const ID = 'transactionDetails';
const INITIAL_DATA = {};
Copy link
Member Author

@sorenlouv sorenlouv Nov 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This defaulted transaction to {} when the value was null. This was good in a pre-typescript world where we had to code defensively but now it just causes problems.
This was the case here:
https://github.com/elastic/kibana/blob/master/x-pack/plugins/apm/public/components/app/TransactionDetails/view.tsx#L67

Since !{} is false, the guard was never hit.

const withInitialData = createInitialDataSelector(INITIAL_DATA);

export function getTransactionDetails(state: IReduxState) {
return withInitialData(state.reactReduxRequest[ID]);
return state.reactReduxRequest[ID];
}

export function TransactionDetailsRequest({
Expand Down