[Discover] [Group by] Support restoring UI state when switching tabs#252888
Closed
davismcphee wants to merge 23 commits into
Closed
[Discover] [Group by] Support restoring UI state when switching tabs#252888davismcphee wants to merge 23 commits into
davismcphee wants to merge 23 commits into
Conversation
davismcphee
added
release_note:skip
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
…e dependencies on global services, which can trigger when switching tabs
eokoneyo
force-pushed
the
discover-group-by-ui-state
branch
from
2cf63d5 to
b6b0033
Compare
eokoneyo
reviewed
Feb 16, 2026
eokoneyo
force-pushed
the
discover-group-by-ui-state
branch
from
6a1b128 to
615aced
Compare
eokoneyo
reviewed
Feb 17, 2026
Comment on lines
-136
to
-155
| useEffect( | ||
| () => () => { | ||
| // ensure that for a row that's been scrolled, | ||
| // if said row is technically still in view because it's cell is being rendered, | ||
| // when we are unmounting because the expand action from the cell's row was clicked, | ||
| // we want to ensure said row is the top most item in our list | ||
| if ( | ||
| virtualRow?.index && | ||
| !rootVirtualizer.isScrolling && | ||
| getScrollOffset() > getScrollMargin() | ||
| ) { | ||
| rootVirtualizer.scrollToVirtualizedIndex(virtualRow.index, { | ||
| align: 'start', | ||
| behavior: 'auto', | ||
| }); | ||
| } | ||
| }, | ||
| [rootVirtualizer, virtualRow?.index, getScrollOffset, getScrollMargin] | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
Removed this as it would cause the scrollOffset to be reset when a state persistence happens and undo the initial scrollOffset passed along
Contributor
Author
|
Closing in favour of #253608. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WIP.
Resolves #249456.
Checklist
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.