Skip to content

[Response Ops][Connectors] Add new user token SO #252501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcger merged 23 commits into from
Feb 18, 2026
Merged

[Response Ops][Connectors] Add new user token SO #252501

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
464736f
user token SO
jcger Feb 6, 2026
f6762a2
separated user_connector_token_client
jcger Feb 9, 2026
819dab0
refactor
jcger Feb 10, 2026
8f01e76
add logger
jcger Feb 10, 2026
d73d4f1
Changes from node scripts/check_mappings_update --fix
kibanamachine Feb 10, 2026
4bb57b7
fix types + linter issues
jcger Feb 11, 2026
9e7f42b
rename token clients
jcger Feb 11, 2026
f3e7a27
Merge branch 'issue-250979-user-token-so' of github.com:jcger/kibana …
jcger Feb 11, 2026
8ff5004
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine Feb 11, 2026
a16fcd6
fix type issues
jcger Feb 11, 2026
3fe2459
Merge branch 'issue-250979-user-token-so' of github.com:jcger/kibana …
jcger Feb 11, 2026
9de1728
use per-user instead of personal
jcger Feb 12, 2026
c068512
Merge branch 'connectors-auth-code-grant' into issue-250979-user-toke…
jcger Feb 12, 2026
0569c06
connector token client does not change id
jcger Feb 12, 2026
e04c658
Merge branch 'issue-250979-user-token-so' of github.com:jcger/kibana …
jcger Feb 12, 2026
92dc41f
copilot review
jcger Feb 12, 2026
1c7b72e
registered SO update
jcger Feb 12, 2026
6752aa7
SO config changes
jcger Feb 13, 2026
9e0eccb
rollback
jcger Feb 16, 2026
987e242
Merge branch 'connectors-auth-code-grant' into issue-250979-user-toke…
jcger Feb 16, 2026
6483ef2
Apply suggestions from code review
jcger Feb 17, 2026
7cd83db
refactor
jcger Feb 17, 2026
dd3af77
Merge branch 'connectors-auth-code-grant' into issue-250979-user-toke…
jcger Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/platform/plugins/shared/actions/server/constants/saved_objects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ export const ALERT_SAVED_OBJECT_TYPE = 'alert';
export const ACTION_TASK_PARAMS_SAVED_OBJECT_TYPE = 'action_task_params';
export const CONNECTOR_TOKEN_SAVED_OBJECT_TYPE = 'connector_token';
export const OAUTH_STATE_SAVED_OBJECT_TYPE = 'oauth_state';
export const USER_CONNECTOR_TOKEN_SAVED_OBJECT_TYPE = 'user_connector_token';
1 change: 1 addition & 0 deletions x-pack/platform/plugins/shared/actions/server/lib/connector_token_client.mock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const createConnectorTokenClientMock = () => {
const mocked: jest.Mocked<PublicMethodsOf<ConnectorTokenClient>> = {
create: jest.fn(),
get: jest.fn(),
getOAuthPersonalToken: jest.fn(),
update: jest.fn(),
deleteConnectorTokens: jest.fn(),
updateOrReplace: jest.fn(),
Expand Down
9 changes: 6 additions & 3 deletions x-pack/platform/plugins/shared/actions/server/lib/connector_token_client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ import type { Logger } from '@kbn/core/server';
import type { ConnectorToken } from '../types';
import * as allRetry from './retry_if_conflicts';

const logger = loggingSystemMock.create().get() as jest.Mocked<Logger>;
const rootLogger = loggingSystemMock.create().get() as jest.Mocked<Logger>;
const logger = {
...rootLogger,
get: () => rootLogger,
} as unknown as Logger;
jest.mock('@kbn/core-saved-objects-utils-server', () => {
const actual = jest.requireActual('@kbn/core-saved-objects-utils-server');
return {
Expand Down Expand Up @@ -412,8 +416,7 @@ describe('delete()', () => {
],
};
unsecuredSavedObjectsClient.find.mockResolvedValueOnce(findResult);
const result = await connectorTokenClient.deleteConnectorTokens({ connectorId: '1' });
expect(JSON.stringify(result)).toEqual(JSON.stringify([Symbol(), Symbol()]));
await connectorTokenClient.deleteConnectorTokens({ connectorId: '1' });

@jcger jcger Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we weren't using return result anywhere, we always call this function like in here. Therefore I felt confident to remove lines 415-416

expect(unsecuredSavedObjectsClient.delete).toHaveBeenCalledTimes(2);
expect(unsecuredSavedObjectsClient.delete.mock.calls[0]).toMatchInlineSnapshot(`
Array [
Expand Down
Loading