Appends search_type=count when size is 0 #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I wouldn't mind @spenceralger confirming this is the best way to inject this into the request as well... |
Contributor
|
This LGTM, and with the last addition really cleans up the spy. Merge master and push it! |
Conflicts: src/kibana/components/courier/fetch/strategy/search.js
w33ble
added a commit
that referenced
this pull request
Jan 6, 2015
Appends search_type=count when size is 0
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
This enables sorting of defined series for ordering in rendering, legend and tooltip for xy charts. BREAKING CHANGE: The way mixed stacked/nonstacked series are colored now is different from the previous behaviour. Now we color them not by their insert index but by the way we display them in the rendering: from the left to right, bottom top, stacked, nonstacked. This align correctly also the legend colors by default. This does **not** affect colors assigned via a `SeriesColorAccessor`.
edmarmoretti
pushed a commit
to edmarmoretti/kibana-pt-br
that referenced
this pull request
Sep 7, 2025
# [68.0.0](elastic/elastic-charts@v67.0.1...v68.0.0) (2024-10-08) ### Features * **xy:** render sorting ([elastic#2524](elastic/elastic-charts#2524)) ([c514571](elastic/elastic-charts@c514571)) ### BREAKING CHANGES * **xy:** The way mixed stacked/nonstacked series are colored now is different from the previous behaviour. Now we color them not by their insert index but by the way we display them in the rendering: from the left to right, bottom top, stacked, nonstacked. This align correctly also the legend colors by default. This does **not** affect colors assigned via a `SeriesColorAccessor`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1951
This is done by checking the
sizevalue in the body when flattening the source state, and appendingflatState.search_type = 'count', which is then appended to the_msearchrequest.This is the correct way to use
search_typewith_msearch, according to the docs