Skip to content

[Fleet] Make save_knowledge_base async in streaming state machine #252328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nchaulet merged 3 commits into from
Feb 10, 2026
+29 −3
Merged

[Fleet] Make save_knowledge_base async in streaming state machine #252328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
94bc774
Initial plan
Copilot Feb 9, 2026
12b4786
Add isAsync flag to save_knowledge_base in streamingStatesDefinition …
Copilot Feb 9, 2026
8068376
Add parity test for state machine isAsync flags
Copilot Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion ...server/services/epm/packages/install_state_machine/_state_machine_package_install.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ import { installIndexTemplatesAndPipelines } from '../install_index_template_pip
import { createArchiveIteratorFromMap } from '../../archive/archive_iterator';

import { handleState } from './state_machine';
import { _stateMachineInstallPackage } from './_state_machine_package_install';
import {
_stateMachineInstallPackage,
regularStatesDefinition,
streamingStatesDefinition,
} from './_state_machine_package_install';
import { cleanupLatestExecutedState } from './steps';

jest.mock('./state_machine');
Expand Down Expand Up @@ -347,3 +351,24 @@ describe('_stateMachineInstallPackage', () => {
await expect(installPromise).rejects.toThrowError(PackageSavedObjectConflictError);
});
});

describe('State machine parity', () => {
it('should have matching isAsync flags for common states in both regularStatesDefinition and streamingStatesDefinition', () => {
const commonStates = [
'create_restart_installation',
'install_kibana_assets',
'save_archive_entries_from_assets_map',
'save_knowledge_base',
'update_so',
] as const;

commonStates.forEach((stateName) => {
const regularState = regularStatesDefinition[stateName];
const streamingState = streamingStatesDefinition[stateName];

if (regularState && streamingState) {
expect(regularState.isAsync).toEqual(streamingState.isAsync);
}
});
});
});
5 changes: 3 additions & 2 deletions ...leet/server/services/epm/packages/install_state_machine/_state_machine_package_install.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export interface InstallContext extends StateContext<StateNames> {
/**
* This data structure defines the sequence of the states and the transitions
*/
const regularStatesDefinition: StateMachineStates<StateNames> = {
export const regularStatesDefinition: StateMachineStates<StateNames> = {
create_restart_installation: {
nextState: INSTALL_STATES.INSTALL_PRECHECK,
onTransition: stepCreateRestartInstallation,
Expand Down Expand Up @@ -182,7 +182,7 @@ const regularStatesDefinition: StateMachineStates<StateNames> = {
},
};

const streamingStatesDefinition: StateMachineStates<string> = {
export const streamingStatesDefinition: StateMachineStates<string> = {
create_restart_installation: {
nextState: INSTALL_STATES.INSTALL_KIBANA_ASSETS,
onTransition: stepCreateRestartInstallation,
Expand All @@ -204,6 +204,7 @@ const streamingStatesDefinition: StateMachineStates<string> = {
onTransition: stepSaveKnowledgeBase,
nextState: INSTALL_STATES.UPDATE_SO,
onPostTransition: updateLatestExecutedState,
isAsync: true, // Knowledge base indexing runs in background
},
update_so: {
onPreTransition: cleanUpUnusedKibanaAssetsStep,
Expand Down
Loading