translate InfraOps visualization component (Part 4 - server part)#25217
Merged
tibmt merged 10 commits intoelastic:masterfrom Nov 26, 2018
Merged
translate InfraOps visualization component (Part 4 - server part)#25217tibmt merged 10 commits intoelastic:masterfrom
tibmt merged 10 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
maryia-lapata
approved these changes
Nov 13, 2018
Contributor
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
Looks good!
just small comments
x-pack/plugins/infra/server/lib/adapters/metrics/kibana_metrics_adapter.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/infra/server/lib/adapters/metrics/kibana_metrics_adapter.ts
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
4 tasks
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
weltenwort
approved these changes
Nov 21, 2018
Member
weltenwort
left a comment
weltenwort
left a comment
There was a problem hiding this comment.
LGTM, just one small id suggestion
x-pack/plugins/infra/server/lib/adapters/metrics/kibana_metrics_adapter.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
tibmt
added a commit
to tibmt/kibana
that referenced
this pull request
Nov 26, 2018
…astic#25217) * translate InfraOps visualization component (Part 4 - server part) * update translation of Infra Ops vizualization component (Part 4) * remove unnessesary translations * change some ids * change some ids * change one id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
translate InfraOps visualization component (Part 4 - server part)
Issue #25523