Skip to content

[Scout] Migrate Data Views API tests from FTR - Part1#252122

Merged
fake-haris merged 41 commits intoelastic:mainfrom
fake-haris:migrate-data-views-tests-to-scout
Feb 17, 2026
Merged

[Scout] Migrate Data Views API tests from FTR - Part1#252122
fake-haris merged 41 commits intoelastic:mainfrom
fake-haris:migrate-data-views-tests-to-scout

Conversation

@fake-haris
Copy link
Copy Markdown
Contributor

@fake-haris fake-haris commented Feb 6, 2026

Summary

Partially migrates Data Views API tests to Scout and improves API-key handling in Scout fixtures.

Details

  • Optimized the invalidateApiKeys function in the requestAuth fixture.
  • Migrated FTR test files:
    • create_data_view/validation.ts
    • create_data_view/main.ts
    • create_data_view/main.ts (the spaces describe block at the bottom)
    • delete_data_view/errors.ts
  • New Scout test files:
    • data_views_crud_create_validation.spec.ts
    • data_views_crud_create_main.spec.ts
    • data_views_crud_create_spaces.spec.ts
    • data_views_crud_delete_errors.spec.ts
    • index_patterns_validation.spec.ts
    • index_patterns_crud_create_main.spec.ts
    • index_patterns_crud_delete_errors.spec.ts

@fake-haris fake-haris self-assigned this Feb 6, 2026
@fake-haris fake-haris added Team:QA Platform QA t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Feb 6, 2026
@fake-haris fake-haris marked this pull request as ready for review February 9, 2026 15:47
@fake-haris fake-haris requested review from a team as code owners February 9, 2026 15:47
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/appex-qa (Team:QA)

@fake-haris
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@fake-haris
Copy link
Copy Markdown
Contributor Author

/ci

@@ -0,0 +1,115 @@
# Data Views API Tests - Scout Migration
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely don't want to commit this file.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would be useful for future reference. Do you think that I should remove it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add the migration details to the PR, so we can have them as future reference. I don't know if adding them to the Kibana repo adds much value to the tests.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the pr description with the migration details but in the README there is the also the list of the pending migration test files. I suggest to keep it until the full migration is done for the owners to have better/easier overview of the progress.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don't find this especially helpful tbh and think it would be better to put pending files in a GH issue, but not a blocker.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it. 👍

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#10773

  • src/platform/plugins/shared/data_views/test/scout/api/playwright.config.ts x20

Copy link
Copy Markdown
Member

@csr csr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 great job!

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10773

[✅] src/platform/plugins/shared/data_views/test/scout/api/playwright.config.ts: 20/20 tests passed.

see run history

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #1 / Filters should render correct filter
  • [job] [logs] Jest Tests #1 / Filters should render filters component

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/scout 249 250 +1
@kbn/scout-oblt 255 256 +1
@kbn/scout-search 244 245 +1
@kbn/scout-security 257 258 +1
total +4

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/scout 31 32 +1
Unknown metric groups

API count

id before after diff
@kbn/scout 614 615 +1
@kbn/scout-oblt 605 606 +1
@kbn/scout-search 594 595 +1
@kbn/scout-security 607 608 +1
total +4

History

cc @fake-haris

@fake-haris fake-haris added backport:all-open Backport to all branches that could still receive a release and removed backport:skip This PR does not require backporting labels Feb 17, 2026
@fake-haris fake-haris merged commit 4d5391b into elastic:main Feb 17, 2026
19 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19, 9.2, 9.3

https://github.com/elastic/kibana/actions/runs/22100710275

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.2 Backport failed because of merge conflicts
9.3 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.3:
- [scout] discover tests with custom server configs (#251297)

Manual backport

To create the backport manually run:

node scripts/backport --pr 252122

Questions ?

Please refer to the Backport tool documentation

paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this pull request Feb 17, 2026
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 18, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 252122 locally
cc: @fake-haris

fake-haris added a commit to fake-haris/kibana that referenced this pull request Feb 18, 2026
(cherry picked from commit 4d5391b)

# Conflicts:
#	.buildkite/scout_ci_config.yml
fake-haris added a commit to fake-haris/kibana that referenced this pull request Feb 18, 2026
(cherry picked from commit 4d5391b)

# Conflicts:
#	.buildkite/scout_ci_config.yml
@fake-haris
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
9.3
9.2
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

fake-haris added a commit to fake-haris/kibana that referenced this pull request Feb 18, 2026
(cherry picked from commit 4d5391b)

# Conflicts:
#	.buildkite/scout_ci_config.yml
#	src/platform/plugins/shared/data_views/test/scout/api/playwright.config.ts
#	src/platform/plugins/shared/data_views/test/scout/api/tests/data_views/crud_delete_errors.spec.ts
#	src/platform/test/api_integration/apis/data_views/data_views_crud/create_data_view/main.ts
#	src/platform/test/api_integration/apis/data_views/data_views_crud/create_data_view/validation.ts
patrykkopycinski pushed a commit to patrykkopycinski/kibana that referenced this pull request Feb 19, 2026
fake-haris added a commit that referenced this pull request Feb 19, 2026
#253732)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Scout] Migrate Data Views API tests from FTR - Part1
(#252122)](#252122)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Charis
Kalpakis","email":"39087493+fake-haris@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-02-17T13:40:00Z","message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:QA","release_note:skip","backport
missing","backport:all-open","v9.4.0"],"title":"[Scout] Migrate Data
Views API tests from FTR -
Part1","number":252122,"url":"https://github.com/elastic/kibana/pull/252122","mergeCommit":{"message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/252122","number":252122,"mergeCommit":{"message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
fake-haris added a commit that referenced this pull request Feb 19, 2026
…#253730)

# Backport

This will backport the following commits from `main` to `9.2`:
- [[Scout] Migrate Data Views API tests from FTR - Part1
(#252122)](#252122)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Charis
Kalpakis","email":"39087493+fake-haris@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-02-17T13:40:00Z","message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:QA","release_note:skip","backport
missing","backport:all-open","v9.4.0"],"title":"[Scout] Migrate Data
Views API tests from FTR -
Part1","number":252122,"url":"https://github.com/elastic/kibana/pull/252122","mergeCommit":{"message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/252122","number":252122,"mergeCommit":{"message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb"}}]}]
BACKPORT-->
fake-haris added a commit that referenced this pull request Feb 19, 2026
…#253727)

# Backport

This will backport the following commits from `main` to `9.3`:
- [[Scout] Migrate Data Views API tests from FTR - Part1
(#252122)](#252122)

<!--- Backport version: 10.2.0 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Charis
Kalpakis","email":"39087493+fake-haris@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-02-17T13:40:00Z","message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:QA","release_note:skip","backport
missing","backport:all-open","v9.4.0"],"title":"[Scout] Migrate Data
Views API tests from FTR -
Part1","number":252122,"url":"https://github.com/elastic/kibana/pull/252122","mergeCommit":{"message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/252122","number":252122,"mergeCommit":{"message":"[Scout]
Migrate Data Views API tests from FTR - Part1
(#252122)","sha":"4d5391ba18c8fbf011101ee05b6dfd9103be36bb"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v9.2.6 v9.3.1 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Feb 19, 2026
ersin-erdal pushed a commit to ersin-erdal/kibana that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// v8.19.12 v9.2.6 v9.3.1 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants