-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[WorkplaceAI][PerUserAuth] Implement Encrypted Saved Objects recommendations #252104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
08ef5a0
Wrap in createModelVersion for ESO
lorenabalan bb88fc9
Reduce AAD fields
lorenabalan 2c7519d
Merge branch 'connectors-auth-code-grant' into lb/fix-eso
lorenabalan cfac73e
Finalize AAD fields
lorenabalan 4f90ecb
Remove redirectUri from AAD
lorenabalan 66acb29
Merge branch 'connectors-auth-code-grant' into lb/fix-eso
lorenabalan 2bd0ccf
Fix tests
lorenabalan 57c1028
Changes from node scripts/jest_integration -u src/core/server/integra…
kibanamachine 980dca9
Merge branch 'connectors-auth-code-grant' into lb/fix-eso
lorenabalan 53387ea
Merge branch 'connectors-auth-code-grant' into lb/fix-eso
lorenabalan adbc880
Merge branch 'connectors-auth-code-grant' into lb/fix-eso
lorenabalan db62932
Changes from make api-docs
kibanamachine cbff161
Changes from node scripts/jest_integration -u src/core/server/integra…
kibanamachine 7f70f2b
Merge branch 'connectors-auth-code-grant' into lb/fix-eso
lorenabalan 0205bd9
Update snapshottt
lorenabalan 99625e1
Merge branch 'connectors-auth-code-grant' into lb/fix-eso
lorenabalan 9474dc4
Fix post-merge
lorenabalan c29f9f1
Update snapshot
lorenabalan 3bdb05e
Fix test
lorenabalan dd2171f
Fix unintentional change from merge
lorenabalan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -120,9 +120,6 @@ export const oauthStateMappings: SavedObjectsTypeMappingDefinition = { | |
| // redirectUri: { | ||
| // type: 'keyword', | ||
| // }, | ||
| // authorizationUrl: { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This field doesn't actually look like it exists anymore looking at the schema, must've been a leftover from a refactoring. |
||
| // type: 'keyword', | ||
| // }, | ||
| // scope: { | ||
| // type: 'keyword', | ||
| // }, | ||
|
|
@@ -135,5 +132,8 @@ export const oauthStateMappings: SavedObjectsTypeMappingDefinition = { | |
| // kibanaReturnUrl: { | ||
| // type: 'keyword', | ||
| // }, | ||
| // spaceId: { | ||
| // type: 'keyword', | ||
| // }, | ||
| }, | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.