-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[ResponseOps][Rules] Add xpack.alerting.rules.apiKeyType config #251899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
12cfff1
e17403a
a955bbc
842acfd
41796b4
7cbd72e
7a36cfb
59d52b4
c3fb1cb
4e15cec
2f61264
bc4de28
24302ad
ee34d1e
18ace47
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -733,6 +733,7 @@ export class AlertingPlugin { | |
| usageCounter: this.usageCounter, | ||
| getEventLogClient: (request: KibanaRequest) => plugins.eventLog.getClient(request), | ||
| isServerless: this.isServerless, | ||
| apiKeyType: this.config.rules.apiKeyType ?? 'es', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. enum could be used here too. |
||
| }); | ||
|
|
||
| this.eventLogService!.registerSavedObjectProvider( | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -185,6 +185,7 @@ export interface TaskRunnerContext { | |
| maxAlerts: number; | ||
| ruleTypeRegistry: RuleTypeRegistry; | ||
| rulesSettingsService: RulesSettingsService; | ||
| apiKeyType: 'es' | 'uiam'; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: Can we create an enum in the types files and use it where ever we use these strings?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Absolutely! |
||
| savedObjects: SavedObjectsServiceStart; | ||
| share: SharePluginStart; | ||
| spaceIdToNamespace: SpaceIdToNamespaceFunction; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.