SO CI Update: Run rollback tests in test mode when no SO types are updated#251139
Merged
hammad-nasir-elastic merged 17 commits intoelastic:mainfrom Feb 9, 2026
Merged
Conversation
- Added a new task to fallback to test mode when no real saved object types have been updated, ensuring migration logic is tested on every PR. - Updated TaskContext to include a flag for fallback mode. - Adjusted automated rollback tests to utilize test baseline mappings in both test and fallback modes.
hammad-nasir-elastic
added
release_note:skip
…n the pull request pipeline.
jbudz
approved these changes
Feb 2, 2026
Contributor
jbudz
left a comment
jbudz
left a comment
There was a problem hiding this comment.
.buildkite/scripts/pipelines/pull_request/pipeline.ts lgtm
- Removed fallback to test mode functionality and related tasks. - Introduced new validation tasks: `validateSOChanges` and `validateTestFlow`. - Updated `TaskContext` to remove `fallbackToTestMode` property. - Adjusted automated rollback tests to use the new context structure.
gsoldevila
reviewed
Feb 9, 2026
gsoldevila
reviewed
Feb 9, 2026
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
|
Contributor
|
@gsoldevila @hammad-nasir-elastic The failed CI step above is now showing on any open PR that doesn't alter a saved object. Interestingly, the CI build is still considered "passing", even though the build is "broken". Used AI and fixed the JSON file, created a utility to update it in the future. |
Member
|
I have reverted this commit in 505763b as it was blocking PR's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue
Summary
This PR modifies the
check_saved_objectsCLI to always run automated rollback tests as a smoke test, even when no Saved Object type definitions have changed. Previously, the rollback tests were skipped entirely if the CI detected no updates to saved objects, which meant regressions in migration logic could go undetected on PRs that don't modify SO types.Changes/New behavior
When no real SO types have been updated, the CLI now falls back to "test mode" and runs the rollback tests using the built in test types
TEST_TYPESThis provides continuous verification of migration logic on every PR.
How it works
fallbackToTestModetask runsctx.updatedTypeswithTEST_TYPESand setsctx.fallbackToTestMode = trueautomatedRollbackTeststask then runs using test fixtures and baseline mappings