[EDR Workflows] Test improvement: get rid of duplicate test errors in afterAll#251046
Merged
gergoabraham merged 3 commits intoelastic:mainfrom Feb 2, 2026
Merged
Conversation
gergoabraham
added
release_note:skip
gergoabraham
force-pushed
the
get-rid-of-duplicate-test-error
branch
from
15bd0bb to
38bf135
Compare
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
tomsonpl
approved these changes
Jan 30, 2026
Contributor
tomsonpl
left a comment
tomsonpl
left a comment
There was a problem hiding this comment.
Wow closing so many issues with such an interesting find! Thanks for doing it 👍
paul-tavares
approved these changes
Feb 2, 2026
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/21598605551 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 2, 2026
… `afterAll` (elastic#251046) ## Summary This PR makes `unloadEndpointData()` resilient towards empty, `undefined` data. The data can be `undefined`, in case the function ``` indexedData = await endpointTestResources.loadEndpointData(); ``` fails in the `beforeEach` hook because of any reason. This already generates test fail issues (like [this](elastic#249124 (comment))), but then, the test also fails in the `afterAll` with ``` │ "after all" hook in "For each artifact list under management": │ │ TypeError: Cannot read properties of undefined (reading 'hosts') ``` generating another fail issue, or contributing to an existing issue with a new build error, like in [this](elastic#240968). This does not help us at all. : ) It just bloats the number of our failed test issues or fail count. ### Related issues Here are the failed test issues, that seem to be safe to close with this PR. They have the same error message, and are either old, or all the error logs i tested are about the same message: closes elastic#159452 closes elastic#175848 closes elastic#173682 closes elastic#203901 closes elastic#233558 closes elastic#233554 closes elastic#246400 closes elastic#249131 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit 5dd2354)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 2, 2026
… `afterAll` (elastic#251046) ## Summary This PR makes `unloadEndpointData()` resilient towards empty, `undefined` data. The data can be `undefined`, in case the function ``` indexedData = await endpointTestResources.loadEndpointData(); ``` fails in the `beforeEach` hook because of any reason. This already generates test fail issues (like [this](elastic#249124 (comment))), but then, the test also fails in the `afterAll` with ``` │ "after all" hook in "For each artifact list under management": │ │ TypeError: Cannot read properties of undefined (reading 'hosts') ``` generating another fail issue, or contributing to an existing issue with a new build error, like in [this](elastic#240968). This does not help us at all. : ) It just bloats the number of our failed test issues or fail count. ### Related issues Here are the failed test issues, that seem to be safe to close with this PR. They have the same error message, and are either old, or all the error logs i tested are about the same message: closes elastic#159452 closes elastic#175848 closes elastic#173682 closes elastic#203901 closes elastic#233558 closes elastic#233554 closes elastic#246400 closes elastic#249131 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit 5dd2354)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 2, 2026
… `afterAll` (elastic#251046) ## Summary This PR makes `unloadEndpointData()` resilient towards empty, `undefined` data. The data can be `undefined`, in case the function ``` indexedData = await endpointTestResources.loadEndpointData(); ``` fails in the `beforeEach` hook because of any reason. This already generates test fail issues (like [this](elastic#249124 (comment))), but then, the test also fails in the `afterAll` with ``` │ "after all" hook in "For each artifact list under management": │ │ TypeError: Cannot read properties of undefined (reading 'hosts') ``` generating another fail issue, or contributing to an existing issue with a new build error, like in [this](elastic#240968). This does not help us at all. : ) It just bloats the number of our failed test issues or fail count. ### Related issues Here are the failed test issues, that seem to be safe to close with this PR. They have the same error message, and are either old, or all the error logs i tested are about the same message: closes elastic#159452 closes elastic#175848 closes elastic#173682 closes elastic#203901 closes elastic#233558 closes elastic#233554 closes elastic#246400 closes elastic#249131 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit 5dd2354)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 2, 2026
… `afterAll` (elastic#251046) ## Summary This PR makes `unloadEndpointData()` resilient towards empty, `undefined` data. The data can be `undefined`, in case the function ``` indexedData = await endpointTestResources.loadEndpointData(); ``` fails in the `beforeEach` hook because of any reason. This already generates test fail issues (like [this](elastic#249124 (comment))), but then, the test also fails in the `afterAll` with ``` │ "after all" hook in "For each artifact list under management": │ │ TypeError: Cannot read properties of undefined (reading 'hosts') ``` generating another fail issue, or contributing to an existing issue with a new build error, like in [this](elastic#240968). This does not help us at all. : ) It just bloats the number of our failed test issues or fail count. ### Related issues Here are the failed test issues, that seem to be safe to close with this PR. They have the same error message, and are either old, or all the error logs i tested are about the same message: closes elastic#159452 closes elastic#175848 closes elastic#173682 closes elastic#203901 closes elastic#233558 closes elastic#233554 closes elastic#246400 closes elastic#249131 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... (cherry picked from commit 5dd2354)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 2, 2026
…ors in `afterAll` (#251046) (#251281) # Backport This will backport the following commits from `main` to `9.2`: - [[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)](#251046) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2026-02-02T16:34:33Z","message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:all-open","v9.4.0"],"title":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll`","number":251046,"url":"https://github.com/elastic/kibana/pull/251046","mergeCommit":{"message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/251046","number":251046,"mergeCommit":{"message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 2, 2026
…ors in `afterAll` (#251046) (#251282) # Backport This will backport the following commits from `main` to `9.3`: - [[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)](#251046) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2026-02-02T16:34:33Z","message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:all-open","v9.4.0"],"title":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll`","number":251046,"url":"https://github.com/elastic/kibana/pull/251046","mergeCommit":{"message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/251046","number":251046,"mergeCommit":{"message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Feb 2, 2026
…ors in `afterAll` (#251046) (#251280) # Backport This will backport the following commits from `main` to `9.1`: - [[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)](#251046) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2026-02-02T16:34:33Z","message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:all-open","v9.4.0"],"title":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll`","number":251046,"url":"https://github.com/elastic/kibana/pull/251046","mergeCommit":{"message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/251046","number":251046,"mergeCommit":{"message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
10 tasks
kibanamachine
added a commit
that referenced
this pull request
Feb 3, 2026
…rors in `afterAll` (#251046) (#251279) # Backport This will backport the following commits from `main` to `8.19`: - [[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)](#251046) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Gergő Ábrahám","email":"gergo.abraham@elastic.co"},"sourceCommit":{"committedDate":"2026-02-02T16:34:33Z","message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","backport:all-open","v9.4.0"],"title":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll`","number":251046,"url":"https://github.com/elastic/kibana/pull/251046","mergeCommit":{"message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/251046","number":251046,"mergeCommit":{"message":"[EDR Workflows] Test improvement: get rid of duplicate test errors in `afterAll` (#251046)\n\n## Summary\n\nThis PR makes `unloadEndpointData()` resilient towards empty,\n`undefined` data. The data can be `undefined`, in case the function\n```\n indexedData = await endpointTestResources.loadEndpointData();\n```\nfails in the `beforeEach` hook because of any reason. This already\ngenerates test fail issues (like\n[this](https://github.com/elastic/kibana/issues/249124#issuecomment-3823333999)),\nbut then, the test also fails in the `afterAll` with\n```\n │ \"after all\" hook in \"For each artifact list under management\":\n │\n │ TypeError: Cannot read properties of undefined (reading 'hosts')\n```\ngenerating another fail issue, or contributing to an existing issue with\na new build error, like in\n[this](https://github.com/elastic/kibana/issues/240968).\n\nThis does not help us at all. : ) It just bloats the number of our\nfailed test issues or fail count.\n\n### Related issues\n\nHere are the failed test issues, that seem to be safe to close with this\nPR. They have the same error message, and are either old, or all the\nerror logs i tested are about the same message:\ncloses #159452\ncloses #175848\ncloses #173682\ncloses #203901\ncloses #233558\ncloses #233554\ncloses #246400\ncloses #249131\n\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [ ]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [ ] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [ ] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [ ] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [ ] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [ ] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [ ] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...","sha":"5dd235469ac766bf26ba29599e068c5ccbd1351a"}}]}] BACKPORT--> Co-authored-by: Gergő Ábrahám <gergo.abraham@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
unloadEndpointData()resilient towards empty,undefineddata. The data can beundefined, in case the functionfails in the
beforeEachhook because of any reason. This already generates test fail issues (like this), but then, the test also fails in theafterAllwithgenerating another fail issue, or contributing to an existing issue with a new build error, like in this.
This does not help us at all. : ) It just bloats the number of our failed test issues or fail count.
Related issues
Here are the failed test issues, that seem to be safe to close with this PR. They have the same error message, and are either old, or all the error logs i tested are about the same message:
closes #159452
closes #175848
closes #173682
closes #203901
closes #233558
closes #233554
closes #246400
closes #249131
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.