Skip to content

Fix synthtrace fetch usage #250950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afharo merged 2 commits into from
Jan 30, 2026
Merged

Fix synthtrace fetch usage #250950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81e3ccf
Fix synthtrace `fetch` usage
afharo Jan 29, 2026
58dbc6d
Fix eslint error
afharo Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 68 additions & 39 deletions src/platform/packages/shared/kbn-synthtrace/src/cli/utils/get_service_urls.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,50 +34,58 @@ describe('getServiceUrls', () => {
it('should discover local service urls and auth if none provided', async () => {
const expectedValidAuth = 'elastic:changeme';

mockFetchWithAllowedSegments([expectedValidAuth]);
mockFetchWithAllowedSegments([expectedValidAuth, 'http://localhost:5601']);
await expectServiceUrls(undefined, undefined, undefined, {
esUrl: 'http://elastic:changeme@localhost:9200',
kibanaUrl: 'http://elastic:changeme@localhost:5601',
kibanaUrl: 'http://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic:changeme').toString('base64')}`,
},
});
});

it('should discover auth for local service urls', async () => {
const expectedValidAuth = 'elastic:changeme';

mockFetchWithAllowedSegments([expectedValidAuth]);
mockFetchWithAllowedSegments([expectedValidAuth, 'http://localhost:5601']);
await expectServiceUrls('http://localhost:9200', 'http://localhost:5601', undefined, {
esUrl: 'http://elastic:changeme@localhost:9200',
kibanaUrl: 'http://elastic:changeme@localhost:5601',
kibanaUrl: 'http://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic:changeme').toString('base64')}`,
},
});
});

it('should discover target from Kibana URL when target is not provided', async () => {
const kibana = 'http://elastic:changeme@localhost:5601';
const expectedValidAuth = 'elastic:changeme';

mockFetchWithAllowedSegments([expectedValidAuth]);
mockFetchWithAllowedSegments([expectedValidAuth, 'http://localhost:5601']);
await expectServiceUrls(undefined, kibana, undefined, {
esUrl: 'http://elastic:changeme@localhost:9200',
kibanaUrl: 'http://elastic:changeme@localhost:5601',
kibanaUrl: 'http://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic:changeme').toString('base64')}`,
},
});
});

it('should discover Kibana URL from target when Kibana URL is not provided', async () => {
const target = 'http://elastic:changeme@localhost:9200';
const expectedValidAuth = 'elastic:changeme';

mockFetchWithAllowedSegments([expectedValidAuth]);
mockFetchWithAllowedSegments([expectedValidAuth, 'http://localhost:5601']);
await expectServiceUrls(target, undefined, undefined, {
esUrl: 'http://elastic:changeme@localhost:9200',
kibanaUrl: 'http://elastic:changeme@localhost:5601',
kibanaUrl: 'http://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic:changeme').toString('base64')}`,
},
});
});

Expand All @@ -91,7 +99,7 @@ describe('getServiceUrls', () => {
undefined,
{
esUrl: 'http://elastic:changeme@localhost:9200',
kibanaUrl: 'http://elastic:changeme@localhost:5601',
kibanaUrl: 'http://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
},
Expand All @@ -110,7 +118,7 @@ describe('getServiceUrls', () => {
undefined,
{
esUrl: 'http://elastic:changeme@localhost:9200',
kibanaUrl: 'http://elastic:changeme@localhost:5601',
kibanaUrl: 'http://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
},
Expand All @@ -129,9 +137,11 @@ describe('getServiceUrls', () => {
undefined,
{
esUrl: 'http://elastic:changeme@localhost:9200',
kibanaUrl: 'http://elastic:changeme@localhost:5601',
kibanaUrl: 'http://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic:changeme').toString('base64')}`,
},
},
`Could not discover Elasticsearch URL based on Kibana URL ${kibana.replace(authStr, '.*')}.` // On CI auth is stripped
);
Expand All @@ -144,25 +154,30 @@ describe('getServiceUrls', () => {

mockFetchWithAllowedSegments([
`https://${expectedValidAuth}@localhost:9200`,
`http://${expectedValidAuth}@localhost:5601`,
'http://localhost:5601',
]); // Only allow https for ES and http for Kibana
await expectServiceUrls(undefined, undefined, undefined, {
esUrl: 'https://elastic_serverless:changeme@localhost:9200',
kibanaUrl: 'http://elastic_serverless:changeme@localhost:5601',
kibanaUrl: 'http://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic_serverless:changeme').toString('base64')}`,
},
});
});

it('should discover auth for local https service urls', async () => {
const expectedValidAuth = 'elastic_serverless:changeme';

mockFetchWithAllowedSegments([`https://${expectedValidAuth}`]); // Only allow https urls
mockFetchWithAllowedSegments([
'https://elastic_serverless:changeme@localhost:9200',
'https://localhost:5601',
]); // Only allow https urls
await expectServiceUrls('https://localhost:9200', 'https://localhost:5601', undefined, {
esUrl: 'https://elastic_serverless:changeme@localhost:9200',
kibanaUrl: 'https://elastic_serverless:changeme@localhost:5601',
kibanaUrl: 'https://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic_serverless:changeme').toString('base64')}`,
},
});
});

Expand All @@ -182,16 +197,18 @@ describe('getServiceUrls', () => {
it('throws error if target is https but https Kibana is not reachable', async () => {
const target = 'https://elastic_serverless:changeme@localhost:9200';

mockFetchWithAllowedSegments([target, 'http://elastic_serverless:changeme@localhost:5601']); // Only allow http Kibana URL
mockFetchWithAllowedSegments([target, 'http://localhost:5601']); // Only allow http Kibana URL
await expectServiceUrls(
target,
undefined,
undefined,
{
esUrl: 'https://elastic_serverless:changeme@localhost:9200',
kibanaUrl: 'http://elastic_serverless:changeme@localhost:5601',
kibanaUrl: 'https://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic_serverless:changeme').toString('base64')}`,
},
},
`Could not connect to Kibana.`
);
Expand All @@ -200,27 +217,33 @@ describe('getServiceUrls', () => {
it('allows a different https Kibana and a different https ES URL', async () => {
const target = 'https://elastic_serverless:changeme@host-1:9200';
const kibana = 'https://elastic_serverless:changeme@host-2:5601';
const kibanaWithoutAuth = 'https://host-2:5601';

mockFetchWithAllowedSegments([target, kibana]); // Allow both URLs
mockFetchWithAllowedSegments([target, kibanaWithoutAuth]); // Allow both URLs
await expectServiceUrls(target, kibana, undefined, {
esUrl: 'https://elastic_serverless:changeme@host-1:9200',
kibanaUrl: 'https://elastic_serverless:changeme@host-2:5601',
kibanaUrl: 'https://host-2:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic_serverless:changeme').toString('base64')}`,
},
});
});

it('logs the certificate warning if 127.0.0.1 is used', async () => {
const target = 'https://elastic_serverless:changeme@127.0.0.1:9200';
const kibana = 'https://elastic_serverless:changeme@localhost:5601';
const kibanaWithoutAuth = 'https://localhost:5601';

const warnSpy = jest.spyOn(logger, 'warning');
mockFetchWithAllowedSegments([target, kibana]);
mockFetchWithAllowedSegments([target, kibanaWithoutAuth]);
await expectServiceUrls(target, kibana, undefined, {
esUrl: 'https://elastic_serverless:changeme@127.0.0.1:9200',
kibanaUrl: 'https://elastic_serverless:changeme@localhost:5601',
kibanaUrl: 'https://localhost:5601',
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('elastic_serverless:changeme').toString('base64')}`,
},
});

expect(warnSpy).toHaveBeenCalledWith(
Expand All @@ -231,28 +254,34 @@ describe('getServiceUrls', () => {

describe('Elastic Cloud', () => {
it('should discover .kb url if .es target is provided', async () => {
const target = 'https://username:1223334444@cluster.kb.us-west2.gcp.elastic-cloud.com';
const expectedKibanaUrl = target.replace('.es', '.kb');
const target = 'https://username:1223334444@cluster.es.us-west2.gcp.elastic-cloud.com';
const targetWithoutAuth = 'https://cluster.es.us-west2.gcp.elastic-cloud.com';
const expectedKibanaUrl = targetWithoutAuth.replace('.es', '.kb');

mockFetchWithAllowedSegments([target, expectedKibanaUrl]);
await expectServiceUrls(target, undefined, undefined, {
esUrl: target,
kibanaUrl: expectedKibanaUrl,
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('username:1223334444').toString('base64')}`,
},
});
});

it('should discover .es url if .kb Kibana is provided', async () => {
const kibana = 'https://username:1223334444@cluster.kb.us-west2.gcp.elastic-cloud.com';
const kibanaWithoutAuth = 'https://cluster.kb.us-west2.gcp.elastic-cloud.com';
const expectedEsUrl = kibana.replace('.kb', '.es');

mockFetchWithAllowedSegments([kibana, expectedEsUrl]);
mockFetchWithAllowedSegments([kibanaWithoutAuth, expectedEsUrl]);
await expectServiceUrls(undefined, kibana, undefined, {
esUrl: expectedEsUrl,
kibanaUrl: kibana,
kibanaUrl: kibanaWithoutAuth,
esHeaders: undefined,
kibanaHeaders: undefined,
kibanaHeaders: {
Authorization: `Basic ${Buffer.from('username:1223334444').toString('base64')}`,
},
});
});
});
Expand Down
28 changes: 17 additions & 11 deletions src/platform/packages/shared/kbn-synthtrace/src/cli/utils/get_service_urls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,20 @@ async function getKibanaUrl({
};
}

const targetAuth = parse(targetKibanaUrl).auth;
const url = new URL(targetKibanaUrl);
const authHeaders: Record<string, string> = {};
if (url.username || url.password) {
const credentials = `${url.username}:${url.password}`;
authHeaders.Authorization = `Basic ${Buffer.from(credentials).toString('base64')}`;
url.username = '';
url.password = '';
}
targetKibanaUrl = url.toString();

const unredirectedResponse = await fetch(targetKibanaUrl, {
method: 'HEAD',
redirect: 'manual',
headers: authHeaders,
dispatcher: getFetchAgent(targetKibanaUrl),
} as RequestInit);

Expand All @@ -96,28 +105,25 @@ async function getKibanaUrl({
?.replace('/spaces/enter', '')
?.replace('spaces/space_selector', '') || targetKibanaUrl;

const discoveredKibanaUrlWithAuth = format({
...parse(discoveredKibanaUrl),
auth: targetAuth,
});

const redirectedResponse = await fetch(discoveredKibanaUrlWithAuth, {
const redirectedResponse = await fetch(discoveredKibanaUrl, {
method: 'HEAD',
dispatcher: getFetchAgent(discoveredKibanaUrlWithAuth),
headers: authHeaders,
dispatcher: getFetchAgent(discoveredKibanaUrl),
} as RequestInit);

if (redirectedResponse.status !== 200) {
throw new Error(
`Expected HTTP 200 from ${stripAuthIfCi(discoveredKibanaUrlWithAuth)}, got ${
`Expected HTTP 200 from ${stripAuthIfCi(discoveredKibanaUrl)}, got ${
redirectedResponse.status
}`
);
}

logger.debug(`Discovered kibana running at: ${stripAuthIfCi(discoveredKibanaUrlWithAuth)}`);
logger.debug(`Discovered kibana running at: ${stripAuthIfCi(discoveredKibanaUrl)}`);

return {
kibanaUrl: discoveredKibanaUrlWithAuth.replace(/\/$/, ''),
kibanaUrl: discoveredKibanaUrl.replace(/\/$/, ''),
kibanaHeaders: authHeaders,
};
} catch (error) {
throw new Error(
Expand Down
Loading