Skip to content

[APM] Improve contrast of health badges in service inventory #250850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlejandroFrndz merged 1 commit into from
Jan 29, 2026
Merged

[APM] Improve contrast of health badges in service inventory #250850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions x-pack/solutions/observability/plugins/apm/common/service_health_status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import { i18n } from '@kbn/i18n';
import type { EuiThemeComputed } from '@elastic/eui';
import { ML_ANOMALY_SEVERITY } from '@kbn/ml-anomaly-utils/anomaly_severity';
import type { NamedColor } from '@elastic/eui/src/components/icon/named_colors';

export enum ServiceHealthStatus {
healthy = 'healthy',
Expand Down Expand Up @@ -50,19 +51,16 @@ export function getServiceHealthStatusColor(
}
}

export function getServiceHealthStatusBadgeColor(
euiTheme: EuiThemeComputed,
status: ServiceHealthStatus
) {
export function getServiceHealthStatusBadgeColor(status: ServiceHealthStatus): NamedColor {
switch (status) {
case ServiceHealthStatus.healthy:
return euiTheme.colors.severity.success;
return 'success';
case ServiceHealthStatus.warning:
return euiTheme.colors.severity.warning;
return 'warning';
case ServiceHealthStatus.critical:
return euiTheme.colors.severity.risk;
return 'danger';
case ServiceHealthStatus.unknown:
return euiTheme.colors.mediumShade;
return 'default';
}
}

Expand Down
6 changes: 2 additions & 4 deletions ...ability/plugins/apm/public/components/app/service_inventory/service_list/health_badge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,16 @@
*/

import React from 'react';
import { EuiBadge, useEuiTheme } from '@elastic/eui';
import { EuiBadge } from '@elastic/eui';
import type { ServiceHealthStatus } from '../../../../../common/service_health_status';
import {
getServiceHealthStatusBadgeColor,
getServiceHealthStatusLabel,
} from '../../../../../common/service_health_status';

export function HealthBadge({ healthStatus }: { healthStatus: ServiceHealthStatus }) {
const { euiTheme } = useEuiTheme();

return (
<EuiBadge color={getServiceHealthStatusBadgeColor(euiTheme, healthStatus)}>
<EuiBadge color={getServiceHealthStatusBadgeColor(healthStatus)}>
{getServiceHealthStatusLabel(healthStatus)}
</EuiBadge>
);
Expand Down
Loading