Skip to content

[ML] Remove node-fetch dependency in favor of native fetch #250719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afharo merged 16 commits into from
Feb 24, 2026
+48 −8
Merged

[ML] Remove node-fetch dependency in favor of native fetch #250719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
4ff9dc6
[ml-ui] Remove node-fetch dependency in favor of native fetch
afharo Jan 28, 2026
0f4e53e
Fix native fetch authentication for aiops integration tests
afharo Jan 28, 2026
1a166f0
Fix TypeScript error in authHeader type for native fetch
afharo Jan 29, 2026
582e1e0
Merge branch 'main' into remove-node-fetch/ml-ui
afharo Jan 29, 2026
cf04e2d
Merge branch 'main' of github.com:elastic/kibana into remove-node-fet…
afharo Feb 5, 2026
ecab1c9
Remove username and password from the URL
afharo Feb 5, 2026
c4a4800
Read the URL as URL
afharo Feb 5, 2026
c3d7fbb
Merge branch 'main' into remove-node-fetch/ml-ui
afharo Feb 6, 2026
f7d2371
Merge branch 'main' of github.com:elastic/kibana into remove-node-fet…
afharo Feb 18, 2026
6c18836
New attempt
afharo Feb 18, 2026
eddedc0
Merge branch 'main' into remove-node-fetch/ml-ui
rbrtj Feb 19, 2026
c3d4f1d
Merge branch 'main' of github.com:elastic/kibana into remove-node-fet…
afharo Feb 20, 2026
6e96806
New attempt to fix it
afharo Feb 20, 2026
1f91af2
Revert fromWeb(stream)
afharo Feb 20, 2026
94acf20
Fix tests
afharo Feb 20, 2026
6beeee8
Merge branch 'main' into remove-node-fetch/ml-ui
rbrtj Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions x-pack/platform/test/api_integration/apis/aiops/log_rate_analysis_full_analysis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
* 2.0.
*/

import { Readable } from 'stream';
import type { ReadableStream } from 'stream/web';
import { orderBy } from 'lodash';
import fetch from 'node-fetch';
import { format as formatUrl } from 'url';

import expect from '@kbn/expect';
Expand All @@ -28,7 +29,17 @@ export default ({ getService }: FtrProviderContext) => {
const aiops = getService('aiops');
const supertest = getService('supertest');
const config = getService('config');
const kibanaServerUrl = formatUrl(config.get('servers.kibana'));
let kibanaServerUrl = formatUrl(config.get('servers.kibana'));
// Native fetch doesn't support credentials in URLs, so we need to extract them
const parsedUrl = new URL(kibanaServerUrl);
const { username, password } = parsedUrl;
parsedUrl.username = '';
parsedUrl.password = '';
kibanaServerUrl = parsedUrl.toString().slice(0, -1); // Remove trailing slash
const authHeader: Record<string, string> =
username && password
? { Authorization: `Basic ${Buffer.from(`${username}:${password}`).toString('base64')}` }
: {};
const esArchiver = getService('esArchiver');

describe('POST /internal/aiops/log_rate_analysis - full analysis', () => {
Expand Down Expand Up @@ -175,6 +186,7 @@ export default ({ getService }: FtrProviderContext) => {
'Content-Type': 'application/json',
[ELASTIC_HTTP_VERSION_HEADER]: apiVersion,
'kbn-xsrf': 'stream',
...authHeader,
},
body: JSON.stringify(body),
});
Expand All @@ -199,7 +211,10 @@ export default ({ getService }: FtrProviderContext) => {
let chunkCounter = 0;
const parseStreamCallback = (c: number) => (chunkCounter = c);

for await (const action of parseStream(stream, parseStreamCallback)) {
for await (const action of parseStream(
Readable.fromWeb(stream as ReadableStream),
parseStreamCallback
)) {
expect(action.type).not.to.be('error');
data.push(action);
}
Expand Down
21 changes: 18 additions & 3 deletions x-pack/platform/test/api_integration/apis/aiops/log_rate_analysis_groups_only.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@
* 2.0.
*/

import { Readable } from 'stream';
import type { ReadableStream } from 'stream/web';
import { orderBy } from 'lodash';
import fetch from 'node-fetch';
import { format as formatUrl } from 'url';

import expect from '@kbn/expect';
Expand All @@ -29,7 +30,17 @@ export default ({ getService }: FtrProviderContext) => {
const aiops = getService('aiops');
const supertest = getService('supertest');
const config = getService('config');
const kibanaServerUrl = formatUrl(config.get('servers.kibana'));
let kibanaServerUrl = formatUrl(config.get('servers.kibana'));
// Native fetch doesn't support credentials in URLs, so we need to extract them
const parsedUrl = new URL(kibanaServerUrl);
const { username, password } = parsedUrl;
parsedUrl.username = '';
parsedUrl.password = '';
kibanaServerUrl = parsedUrl.toString().slice(0, -1); // Remove trailing slash
const authHeader: Record<string, string> =
username && password
? { Authorization: `Basic ${Buffer.from(`${username}:${password}`).toString('base64')}` }
: {};
const esArchiver = getService('esArchiver');

describe('POST /internal/aiops/log_rate_analysis - groups only', () => {
Expand Down Expand Up @@ -185,6 +196,7 @@ export default ({ getService }: FtrProviderContext) => {
'Content-Type': 'application/json',
[ELASTIC_HTTP_VERSION_HEADER]: apiVersion,
'kbn-xsrf': 'stream',
...authHeader,
},
body: JSON.stringify(body),
});
Expand All @@ -209,7 +221,10 @@ export default ({ getService }: FtrProviderContext) => {
let chunkCounter = 0;
const parseStreamCallback = (c: number) => (chunkCounter = c);

for await (const action of parseStream(stream, parseStreamCallback)) {
for await (const action of parseStream(
Readable.fromWeb(stream as ReadableStream),
parseStreamCallback
)) {
expect(action.type).not.to.be('error');
data.push(action);
}
Expand Down
14 changes: 12 additions & 2 deletions x-pack/platform/test/api_integration_basic/apis/aiops/permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
* 2.0.
*/

import fetch from 'node-fetch';
import { format as formatUrl } from 'url';
import { ELASTIC_HTTP_VERSION_HEADER } from '@kbn/core-http-common';

Expand All @@ -22,7 +21,17 @@ const API_VERSIONS: ApiVersion[] = ['3'];
export default ({ getService }: FtrProviderContext) => {
const supertest = getService('supertest');
const config = getService('config');
const kibanaServerUrl = formatUrl(config.get('servers.kibana'));
let kibanaServerUrl = formatUrl(config.get('servers.kibana'));
// Native fetch doesn't support credentials in URLs, so we need to extract them
const parsedUrl = new URL(kibanaServerUrl);
const { username, password } = parsedUrl;
parsedUrl.username = '';
parsedUrl.password = '';
kibanaServerUrl = parsedUrl.toString().slice(0, -1); // Remove trailing slash
const authHeader: Record<string, string> =
username && password
? { Authorization: `Basic ${Buffer.from(`${username}:${password}`).toString('base64')}` }
: {};

describe('POST /internal/aiops/log_rate_analysis', () => {
API_VERSIONS.forEach((apiVersion) => {
Expand Down Expand Up @@ -55,6 +64,7 @@ export default ({ getService }: FtrProviderContext) => {
'Content-Type': 'application/json',
'kbn-xsrf': 'stream',
[ELASTIC_HTTP_VERSION_HEADER]: apiVersion,
...authHeader,
},
body: JSON.stringify(requestBody),
});
Expand Down
Loading