[kibana-presentation] Remove node-fetch dependency in favor of native fetch#250718
Merged
afharo merged 1 commit intoelastic:mainfrom Jan 29, 2026
Merged
Conversation
… fetch ## Changes - Updated WMS client to use native fetch - Updated glyphs to use native fetch - Updated all related test files > [!WARNING] > These changes were vibe-coded using the AI agent `claude-4.5-opus-high`. Please review carefully.
afharo
added
backport:skip
3 tasks
nickpeihl
approved these changes
Jan 29, 2026
Contributor
nickpeihl
left a comment
nickpeihl
left a comment
There was a problem hiding this comment.
lgtm! code review and confirmed that wms layers and requests for ems fonts are being fetched correctly.
hannahbrooks
pushed a commit
to hannahbrooks/kibana
that referenced
this pull request
Jan 30, 2026
… fetch (elastic#250718) ## Summary This PR removes the `node-fetch` dependency for files owned by `@elastic/kibana-presentation`. ### Why Node.js 18+ includes a native `fetch` API (built on undici internally), making the `node-fetch` package unnecessary. This reduces the dependency footprint by removing one runtime dependency and its transitive dependencies. ### Changes - Updated Maps WMS client to use native fetch - Updated Maps glyphs to use native fetch - Updated all related test files to use `jest.spyOn(global, 'fetch')` > [!WARNING] > These changes were vibe-coded using the AI agent `claude-4.5-opus-high`. Please review carefully. ## Test plan - [x] Type check passes - [x] ESLint passes - [ ] Unit tests pass for modified files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the
node-fetchdependency for files owned by@elastic/kibana-presentation.Why
Node.js 18+ includes a native
fetchAPI (built on undici internally), making thenode-fetchpackage unnecessary. This reduces the dependency footprint by removing one runtime dependency and its transitive dependencies.Changes
jest.spyOn(global, 'fetch')Warning
These changes were vibe-coded using the AI agent
claude-4.5-opus-high. Please review carefully.Test plan