Address @elastic/eui/require-table-caption lint violations across @elastic/actionable-obs-team files#250682
Open
alexwizp wants to merge 9 commits intoelastic:mainfrom
Open
Address @elastic/eui/require-table-caption lint violations across @elastic/actionable-obs-team files#250682alexwizp wants to merge 9 commits intoelastic:mainfrom
@elastic/actionable-obs-team files#250682alexwizp wants to merge 9 commits intoelastic:mainfrom
Conversation
…astic/elastic/obs-ux-management-team files
alexwizp
added
v9.4.0
v9.2.5
v9.3.1
Project:Accessibility
release_note:skip
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
botelastic
bot
added
Team:obs-presentation
Contributor
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
# Conflicts: # x-pack/solutions/observability/plugins/synthetics/public/apps/synthetics/components/certificates/certificates.test.tsx # x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/components/certificates/certificates_list.tsx # x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/pages/certificates.test.tsx
Contributor
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/require-table-caption.This rule ensure
EuiInMemoryTable,EuiBasicTablehave atableCaptionprop for accessibility.Changes
tableCaptionattributes to elements flagged by@elastic/eui/require-table-caption— accessibility leveled up!Related
@elastic/eslint-plugin-eui] added newrequire-table-captionrule. eui#9168This time, to avoid annoying approvals collection, we've broken files down by teams. Now, we are waiting a review only from your team!