Feature/translate monitoring apm and chart#25063
Feature/translate monitoring apm and chart#25063maryia-lapata merged 28 commits intoelastic:masterfrom
Conversation
second merge
💔 Build Failed |
|
retest |
maryia-lapata
left a comment
maryia-lapata
left a comment
There was a problem hiding this comment.
Please also translate this https://github.com/elastic/kibana/pull/25063/files#diff-4d75d804e32b80fb0822600f0ec07ed6R107 and this aria-label https://github.com/elastic/kibana/pull/25063/files#diff-0ef064f29ff71a8209342364eac1180dR66.
I think this label https://github.com/elastic/kibana/pull/25063/files#diff-602f24cdda7e99d7a03dc1bd78347653R29 should be translated.
x-pack/plugins/monitoring/public/components/apm/instance/status.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/public/components/apm/instance/status.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/monitoring/public/components/apm/instances/status.js
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
💔 Build Failed |
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
Mostly great, but a couple issues I found
| value: intl.formatMessage({ | ||
| id: 'xpack.monitoring.apm.instance.status.lastEventDescription', | ||
| defaultMessage: '{timeOfLastEvent} ago' }, { | ||
| timeOfLastEvent: formatTimestampToDuration(+moment(timeOfLastEvent), CALCULATE_DURATION_SINCE) |
There was a problem hiding this comment.
Missing 'since' argument
There was a problem hiding this comment.
'since' it's not a label, it's a kind of key, which is passed as a parameter to function formatTimestampToDuration() . And according to this key timeDuration is calculated differently. So we didn't miss 'since' argument, we just replaced it with a constant like in the other code:
Please correct me if I am wrong.
| value: intl.formatMessage({ | ||
| id: 'xpack.monitoring.apm.instances.status.lastEventDescription', | ||
| defaultMessage: '{timeOfLastEvent} ago' }, { | ||
| timeOfLastEvent: formatTimestampToDuration(+moment(timeOfLastEvent), CALCULATE_DURATION_SINCE) |
There was a problem hiding this comment.
Again here, missing 'since' argument
|
Pinging @elastic/kibana-monitoring |
💔 Build Failed |
💔 Build Failed |
|
Should be merge after #24717. |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
* Translate monitoring - apm * Translate monitoring - chart * Fix issues with apm * Fix issues with chart * Update snapshots
4 participants
Translate monitoring -> public -> components:
monitoring -> public -> directives -> chart;
monitoring -> public -> views -> apm;
Fixes: #24713