Skip to content

Revert "[Security Solution] Skipped tests: flaky Suricata tests" #250296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ikuni17 merged 1 commit into from
Jan 24, 2026
+23 −68
Merged

Revert "[Security Solution] Skipped tests: flaky Suricata tests" #250296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...y/test/security_solution_cypress/cypress/e2e/investigations/timelines/row_renderers.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,15 @@
* 2.0.
*/

import { elementsOverlap } from '../../../helpers/rules';
import {
TIMELINE_ROW_RENDERERS_DISABLE_ALL_BTN,
TIMELINE_ROW_RENDERERS_MODAL_ITEMS_CHECKBOX,
TIMELINE_ROW_RENDERERS_SEARCHBOX,
TIMELINE_SHOW_ROW_RENDERERS_GEAR,
TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE,
TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP,
TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP,
TIMELINE_ROW_RENDERERS_MODAL_CLOSE_BUTTON,
TIMELINE_ROW_RENDERERS_WRAPPER,
} from '../../../screens/timeline';
Expand Down Expand Up @@ -126,4 +130,22 @@ describe('Row renderers', { tags: ['@ess', '@serverless'] }, () => {

cy.wait('@updateTimeline').its('response.statusCode').should('eq', 200);
});

describe('Suricata', () => {
// This test has become very flaky over time and was blocking a lot of PRs.
// A follw-up ticket to tackle this issue has been created.
it.skip('Signature tooltips do not overlap', () => {
// Hover the signature to show the tooltips
cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE).parents('.euiPopover').realHover();

cy.get(TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP).then(($googleLinkTooltip) => {
cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP).then(($signatureTooltip) => {
expect(
elementsOverlap($googleLinkTooltip, $signatureTooltip),
'tooltips do not overlap'
).to.equal(false);
});
});
});
});
});
67 changes: 0 additions & 67 deletions ...curity_solution_cypress/cypress/e2e/investigations/timelines/row_renderers_suricata.cy.ts
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion x-pack/solutions/security/test/security_solution_cypress/cypress/screens/timeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export const TIMELINE_ROW_RENDERERS_SEARCHBOX = `${TIMELINE_ROW_RENDERERS_MODAL}

export const TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE = `${TIMELINE_ROW_RENDERERS_MODAL} [data-test-subj="render-content-suricata.eve.alert.signature"]`;

export const TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP = `[data-test-subj="externalLink"]`;
export const TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP = `[data-test-subj="externalLinkTooltip"]`;

export const TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP = `[data-test-subj="suricata.eve.alert.signature-tooltip"]`;

Expand Down