[Discover] Background search inspect in child flyout#250252
[Discover] Background search inspect in child flyout#250252akowalska622 merged 49 commits intoelastic:mainfrom
Conversation
| coreStart.rendering.addContext( | ||
| <KibanaReactContextProvider> |
There was a problem hiding this comment.
Context is handled in src/core/packages/overlays/browser-internal/src/flyout/system_flyout_service.tsx now
|
just came by to be exited ... would have helped me a lot in the debugging phase of 8.2, so my wish now it having a Time Machine, to backport the commit to September 2025 |
….com:akowalska622/kibana into discover-background-search-inspect-in-flyout
|
/ci |
….com:akowalska622/kibana into discover-background-search-inspect-in-flyout
|
Opening for review again, maybe this time we have more luck 🤞 🍀 |
….com:akowalska622/kibana into discover-background-search-inspect-in-flyout
….com:akowalska622/kibana into discover-background-search-inspect-in-flyout
| export interface IClickActionDescriptor { | ||
| label: React.ReactNode; | ||
| iconType: 'trash' | 'cancel' | typeof extendSessionIcon; | ||
| iconType: string; |
There was a problem hiding this comment.
maybe we can just use IconType from eui
AlexGPlay
left a comment
There was a problem hiding this comment.
lgtm - played with it for a bit and now it works nice! 🚀
andrimal
left a comment
There was a problem hiding this comment.
Code changes LGTM! ✨ Nothing touches Lens or visualizations.
💚 Build Succeeded
Metrics [docs]Module Count
Page load bundle
History
|
Summary
Resolves: #242240
A-la-carte: https://akowalska622-pr-250252-discover-background-search-inspect-i.kbndev.co/
This pull request refactors and modernizes the way flyouts are implemented and opened in the search session management UI. The main improvements include extracting and reusing the
InspectFlyoutcomponent, switching to the newopenSystemFlyoutAPI for overlays, and simplifying context and rendering logic. Additionally, the "Inspect" action is now available in the session management table and renders a connected background search details as a child flyout.Steps to test:
kibana_sample_data_ecommercedataFROM kibana_sample_data_ecommerce | LIMIT 1 | EVAL delay(5000ms)Send to backgroundbutton (adjust delay if you need more time)Background searchesoptionInspectChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.