Skip to content

[9.2] Address @elastic/eui/require-table-caption lint violations across @elastic/ml-ui files (#249699)#250250

Merged
alexwizp merged 3 commits intoelastic:9.2from
alexwizp:backport/9.2/pr-249699
Jan 26, 2026
Merged

[9.2] Address @elastic/eui/require-table-caption lint violations across @elastic/ml-ui files (#249699)#250250
alexwizp merged 3 commits intoelastic:9.2from
alexwizp:backport/9.2/pr-249699

Conversation

@alexwizp
Copy link
Contributor

Backport

This will backport the following commits from main to 9.2:

Questions ?

Please refer to the Backport tool documentation

…@elastic/ml-ui` files (elastic#249699)

> [!CAUTION]
> ⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them
carefully, but your code owners’ expert eyes will ensure they’re 100%
right.

## Summary
This PR applies the auto-fix for the newly introduced
`@elastic/eui/require-table-caption`.
This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a
`tableCaption` prop for accessibility.

## Changes

1. 🎯 Added missing `tableCaption` attributes to elements flagged by
`@elastic/eui/require-table-caption` — accessibility leveled up!

## Related
- elastic/eui#9168

This time, to avoid annoying approvals collection, we've broken files
down by teams. Now, we are waiting a review only from your team!

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Pete Harverson <pete@elastic.co>
(cherry picked from commit 2e91ece)

# Conflicts:
#	x-pack/platform/plugins/private/data_visualizer/public/application/file_data_visualizer/new/file_status/docs_preview.tsx
@alexwizp alexwizp added the backport This PR is a backport of another PR label Jan 23, 2026
@alexwizp alexwizp enabled auto-merge (squash) January 23, 2026 16:12
@bhavyarm bhavyarm self-requested a review January 23, 2026 16:27
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp merged commit 7ba116b into elastic:9.2 Jan 26, 2026
13 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 528.2KB 528.8KB +544.0B
dataVisualizer 596.4KB 596.5KB +123.0B
ml 5.4MB 5.4MB +3.6KB
total +4.2KB

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants