[CI] OAS Snapshots: make snapshot file writing default#250050
Merged
delanni merged 1 commit intoelastic:mainfrom Jan 22, 2026
Merged
[CI] OAS Snapshots: make snapshot file writing default#250050delanni merged 1 commit intoelastic:mainfrom
delanni merged 1 commit intoelastic:mainfrom
Conversation
delanni
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
jloleysens
approved these changes
Jan 22, 2026
Contributor
jloleysens
left a comment
jloleysens
left a comment
There was a problem hiding this comment.
Thanks for picking this up @delanni 👏🏻
| --include-path /api/saved_objects/_export \ | ||
| --include-path /api/maintenance_window \ | ||
| --include-path /api/agent_builder" | ||
| if is_pr && ! is_auto_commit_disabled; then |
Contributor
There was a problem hiding this comment.
I guess we could avoid the extra cleanup of the --update flag if we just added it here, but thanks for doing that!
Member
Author
There was a problem hiding this comment.
@jloleysens
We could have, that's also a valid option - would you prefer that direction? (are there usecases where we don't want to write the file, just run the generation process?)
Contributor
There was a problem hiding this comment.
@delanni Nope, I think it makes sense to remove it. Just would have reduced the surface area of the change here a little bit :)
Contributor
💔 Build Failed
Failed CI Steps
Metrics [docs]
History |
qn895
pushed a commit
to qn895/kibana
that referenced
this pull request
Jan 22, 2026
## Summary elastic#249907 removes the intermediary files for the OAS snapshot validation, however, in the `on-merge` pipeline, the files are not generated, so the merging fails. This PR makes generation default, so we pass this stage in the on-merges.
dennis-tismenko
pushed a commit
to dennis-tismenko/kibana
that referenced
this pull request
Jan 22, 2026
## Summary elastic#249907 removes the intermediary files for the OAS snapshot validation, however, in the `on-merge` pipeline, the files are not generated, so the merging fails. This PR makes generation default, so we pass this stage in the on-merges.
davismcphee
pushed a commit
to davismcphee/kibana
that referenced
this pull request
Jan 28, 2026
elastic#249907 removes the intermediary files for the OAS snapshot validation, however, in the `on-merge` pipeline, the files are not generated, so the merging fails. This PR makes generation default, so we pass this stage in the on-merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#249907 removes the intermediary files for the OAS snapshot validation, however, in the
on-mergepipeline, the files are not generated, so the merging fails.This PR makes generation default, so we pass this stage in the on-merges.