Skip to content

[Fleet] remove authorization header fake request fleet#249914

Merged
nchaulet merged 12 commits intomainfrom
feature-remove-authorization-header-fake-request-fleet
Jan 29, 2026
Merged

[Fleet] remove authorization header fake request fleet#249914
nchaulet merged 12 commits intomainfrom
feature-remove-authorization-header-fake-request-fleet

Conversation

@nchaulet
Copy link
Copy Markdown
Member

@nchaulet nchaulet commented Jan 21, 2026

Summary

Related to #247822

To support UIAM we need to stop using authorization from the request, that PR does that

Tests

Most of our codepath should be covered by e2e tests but it will be interesting to perform some sanity check opertions install/uninstall bulk operations on package using authorization from request for transforms.

@nchaulet nchaulet self-assigned this Jan 26, 2026
@nchaulet nchaulet marked this pull request as ready for review January 26, 2026 20:58
@nchaulet nchaulet requested a review from a team as a code owner January 26, 2026 20:58
@nchaulet
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Jan 26, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

request?: KibanaRequest
) => {
let installedTransforms: EsAssetReference[] = [];
const authorizationHeader = request
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need authorizationHeader to install transforms?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's used to retrieve the username, going to see if there is a better way to retrieve it

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use security service instead

@nchaulet nchaulet requested a review from juliaElastic January 28, 2026 15:28
Copy link
Copy Markdown
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #7 / Migration actions - serverless environment closePit closes PointInTime
  • [job] [logs] Jest Integration Tests #7 / Migration actions - serverless environment closePit closes PointInTime
  • [job] [logs] Scout: [ platform / streams_app-stateful ] plugin / stateful - Stream data processing - outdated documents - with up to date documents - should not display warning tip for kql samples datasource
  • [job] [logs] Scout: [ platform / streams_app-stateful ] plugin / with up to date documents - should not display warning tip for kql samples datasource

History

cc @nchaulet

@nchaulet
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet merged commit fd7cba1 into main Jan 29, 2026
17 checks passed
@nchaulet nchaulet deleted the feature-remove-authorization-header-fake-request-fleet branch January 29, 2026 14:11
hannahbrooks pushed a commit to hannahbrooks/kibana that referenced this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants