Skip to content

[9.2] Address @elastic/eui/require-table-caption lint violations across @elastic/kibana-data-discovery files (#246176)#249877

Merged
alexwizp merged 1 commit intoelastic:9.2from
alexwizp:backport/9.2/pr-246176
Jan 21, 2026
Merged

[9.2] Address @elastic/eui/require-table-caption lint violations across @elastic/kibana-data-discovery files (#246176)#249877
alexwizp merged 1 commit intoelastic:9.2from
alexwizp:backport/9.2/pr-246176

Conversation

@alexwizp
Copy link
Contributor

Backport

This will backport the following commits from main to 9.2:

Questions ?

Please refer to the Backport tool documentation

…@elastic/kibana-data-discovery` files (elastic#246176)

> [!CAUTION]
> ⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them
carefully, but your code owners’ expert eyes will ensure they’re 100%
right.

## Summary
This PR applies the auto-fix for the newly introduced
`@elastic/eui/require-table-caption`.
This rule ensure `EuiInMemoryTable`, `EuiBasicTable` have a
`tableCaption` prop for accessibility.

## Changes

1. 🎯 Added missing `tableCaption` attributes to elements flagged by
`@elastic/eui/require-table-caption` — accessibility leveled up!

## Related
- elastic/eui#9168

This time, to avoid annoying approvals collection, we've broken files
down by teams. Now, we are waiting a review only from your team!

(cherry picked from commit 4d43ef8)

# Conflicts:
#	src/platform/plugins/shared/data_view_management/public/components/edit_index_pattern/relationships_table/i18n.ts
#	src/platform/plugins/shared/data_view_management/public/components/edit_index_pattern/relationships_table/relationships_table.tsx
#	src/platform/plugins/shared/saved_objects_finder/public/finder/saved_object_finder.tsx
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp merged commit 33d7e6d into elastic:9.2 Jan 21, 2026
16 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #71 / Cloud Security Posture Test adding Cloud Security Posture Integrations CSPM AWS CIS_AWS Single Manual Direct Access CIS_AWS Single Manual Direct Access Workflow

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewFieldEditor 100.7KB 102.2KB +1.5KB
dataViewManagement 133.9KB 134.8KB +981.0B
savedObjectsFinder 7.5KB 7.6KB +113.0B
total +2.6KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants