-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Privmon User Count - use grouping with count in place of count distinct for > 4000 users limitation #249775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Privmon User Count - use grouping with count in place of count distinct for > 4000 users limitation #249775
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0b804fe
Privmon User Count using lensAttributes with DSL to allow > 4000 user…
CAWilson94 94f9c97
rename filter query appropriately
CAWilson94 2ebf132
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine ddab774
Removing the DSL changes as a modified ESQL query gets the right results
abhishekbhatia1710 50fd305
Reverting changes to not using DSL for eggbox viz
abhishekbhatia1710 99b4abe
Reverting more changes
abhishekbhatia1710 6288ba9
Merge branch 'main' into eggbox-count
abhishekbhatia1710 65e3a5d
Merge branch 'main' into eggbox-count
abhishekbhatia1710 c4f61dc
Merge branch 'main' into eggbox-count
CAWilson94 ee835db
Removing the STATS BY as the index only stores one entity always.
abhishekbhatia1710 6f068f8
Merge branch 'eggbox-count' of github.com:CAWilson94/kibana into eggb…
abhishekbhatia1710 3699404
Merge branch 'main' into eggbox-count
abhishekbhatia1710 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,4 +11,5 @@ export const getPrivilegedUsersEsqlCount = ( | |
| namespace: string | ||
| ) => `FROM ${getPrivilegedMonitorUsersIndex(namespace)} | ||
| | WHERE user.is_privileged == true | ||
| | STATS count = COUNT_DISTINCT(user.name)`; | ||
| | STATS BY user.name | ||
| | STATS count = COUNT(*)`; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Uh oh!
There was an error while loading. Please reload this page.