Skip to content

[Discover][Traces] Explore trace.id from logs in Discover #249632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tfcmarques merged 15 commits into from
Jan 30, 2026
Merged

[Discover][Traces] Explore trace.id from logs in Discover #249632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0d970c6
remove trace id from summary table + add open in discover to traces s…
tfcmarques Jan 19, 2026
a2301e9
revert summary table trace id removal + remove only hyperlink + updat…
tfcmarques Jan 20, 2026
fd594ec
Merge branch 'main' into 5115-explore-trace-id-from-logs-in-Discover
tfcmarques Jan 20, 2026
5a6cc78
revert highlight removal + minor type change
tfcmarques Jan 20, 2026
73edc63
reuse open in discover label + typo fix
tfcmarques Jan 20, 2026
536a51a
fix translation files
tfcmarques Jan 20, 2026
6590085
fix trace waterfall test mocks
tfcmarques Jan 20, 2026
6846f01
revert target prop from action
tfcmarques Jan 21, 2026
0140d0c
Merge branch 'main' into 5115-explore-trace-id-from-logs-in-Discover
tfcmarques Jan 21, 2026
c226608
switch traces section action buttons order
tfcmarques Jan 21, 2026
8260c00
Merge remote-tracking branch 'upstream/main' into 5115-explore-trace-…
tfcmarques Jan 21, 2026
9444701
Merge branch 'main' into 5115-explore-trace-id-from-logs-in-Discover
tfcmarques Jan 26, 2026
47df69f
Merge remote-tracking branch 'upstream/main' into 5115-explore-trace-…
tfcmarques Jan 26, 2026
67c7282
Merge remote-tracking branch 'upstream/main' into 5115-explore-trace-…
tfcmarques Jan 28, 2026
21fa102
Merge remote-tracking branch 'upstream/main' into 5115-explore-trace-…
tfcmarques Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions ...ared/unified_doc_viewer/public/components/doc_viewer_logs_overview/logs_overview.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,10 +402,12 @@ describe('LogsOverview with APM links', () => {
).not.toBeInTheDocument();
});

it('should render trace id link', () => {
expect(
screen.queryByTestId('unifiedDocViewLogsOverviewTraceIdHighlightLink')
).toBeInTheDocument();
it('should render trace id without a link', () => {
const traceId = screen.getByTestId('unifiedDocViewLogsOverviewTraceID');
expect(traceId).toBeInTheDocument();

const traceLink = traceId.querySelector('a');
expect(traceLink).toBeNull();
});
});
});
Expand Down
12 changes: 1 addition & 11 deletions ...nified_doc_viewer/public/components/doc_viewer_logs_overview/logs_overview_highlights.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { EuiBadge, EuiPanel } from '@elastic/eui';
import type { FieldConfiguration } from '../content_framework';
import { ContentFrameworkTable } from '../content_framework';
import { HighlightField } from '../observability/traces/components/highlight_field';
import { TraceIdLink } from '../observability/traces/components/trace_id_link';
import { fieldLabels } from '../observability/constants';

interface LogsOverviewHighlightsProps
Expand Down Expand Up @@ -93,15 +92,7 @@ const fieldConfigurations: Record<string, FieldConfiguration> = {
[fieldConstants.TRACE_ID_FIELD]: {
title: fieldLabels.TRACE_ID_LABEL,
formatter: (value: unknown, formattedValue: string) => (
<HighlightField value={value as string} formattedValue={formattedValue}>
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to keep the highlighting and only remove the link?

Copy link
Copy Markdown
Contributor Author

@tfcmarques tfcmarques Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's true, I'll quickly revert that, thanks 👍🏻

Copy link
Copy Markdown
Contributor Author

@tfcmarques tfcmarques Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Friendly reminder that it doesn't change the demo, because we're using ESQL there 🙇🏻

Screenshot 2026-01-20 at 15 05 42

{({ content }) => (
<TraceIdLink
traceId={value as string}
formattedTraceId={content}
data-test-subj="unifiedDocViewLogsOverviewTraceIdHighlightLink"
/>
)}
</HighlightField>
<HighlightField value={value as string} formattedValue={formattedValue} />
),
},
[fieldConstants.ORCHESTRATOR_CLUSTER_NAME_FIELD]: {
Expand Down Expand Up @@ -135,7 +126,6 @@ const fieldConfigurations: Record<string, FieldConfiguration> = {
},
[fieldConstants.DATASTREAM_NAMESPACE_FIELD]: {
title: fieldLabels.DATASTREAM_NAMESPACE_LABEL,

formatter: (value, formattedValue) => (
<HighlightField value={value as string} formattedValue={formattedValue}>
{({ content }) => <EuiBadge color="hollow">{content}</EuiBadge>}
Expand Down
4 changes: 2 additions & 2 deletions ...gins/shared/unified_doc_viewer/public/components/observability/traces/common/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export const OPEN_IN_DISCOVER_LABEL = i18n.translate(
}
);

export const OPEN_IN_DISCOVER_LABEL_ARIAL_LABEL = i18n.translate(
'unifiedDocViewer.observability.traces.openInDiscoverArialLabel',
export const OPEN_IN_DISCOVER_ARIA_LABEL = i18n.translate(
Copy link
Copy Markdown
Contributor Author

@tfcmarques tfcmarques Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing typo ARIAL -> ARIA

'unifiedDocViewer.observability.traces.openInDiscoverAriaLabel',
{ defaultMessage: 'Open in discover link' }
);

Expand Down
11 changes: 1 addition & 10 deletions ...c_viewer/public/components/observability/traces/components/about/field_configurations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ import { ServiceNameLink } from '../service_name_link';
import { TransactionNameLink } from '../transaction_name_link';
import { HighlightField } from '../highlight_field';
import { DependencyNameLink } from '../dependency_name_link';
import { TraceIdLink } from '../trace_id_link';
import { fieldDescriptions, fieldLabels } from '../../../constants';

export const getSharedFieldConfigurations = (
Expand Down Expand Up @@ -73,15 +72,7 @@ export const getSharedFieldConfigurations = (
[TRACE_ID]: {
title: fieldLabels.TRACE_ID_LABEL,
formatter: (value: unknown, formattedValue: string) => (
<HighlightField value={value as string} formattedValue={formattedValue}>
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

{({ content }) => (
<TraceIdLink
traceId={value as string}
formattedTraceId={content}
data-test-subj="unifiedDocViewerObservabilityTracesTraceIdLink"
/>
)}
</HighlightField>
<HighlightField value={value as string} formattedValue={formattedValue} />
),
},
};
Expand Down
4 changes: 2 additions & 2 deletions ...fied_doc_viewer/public/components/observability/traces/components/errors/errors_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { getColumns } from './get_columns';
import { useFetchErrorsByTraceId } from './use_fetch_errors_by_trace_id';
import { useDataSourcesContext } from '../../../../../hooks/use_data_sources';
import { useGetGenerateDiscoverLink } from '../../../../../hooks/use_generate_discover_link';
import { OPEN_IN_DISCOVER_LABEL, OPEN_IN_DISCOVER_LABEL_ARIAL_LABEL } from '../../common/constants';
import { OPEN_IN_DISCOVER_LABEL, OPEN_IN_DISCOVER_ARIA_LABEL } from '../../common/constants';
import { createTraceContextWhereClauseForErrors } from '../../common/create_trace_context_where_clause';
import {
ScrollableSectionWrapper,
Expand Down Expand Up @@ -89,7 +89,7 @@ export const ErrorsTable = forwardRef<ScrollableSectionWrapperApi, Props>(
{
icon: 'discoverApp',
label: OPEN_IN_DISCOVER_LABEL,
ariaLabel: OPEN_IN_DISCOVER_LABEL_ARIAL_LABEL,
ariaLabel: OPEN_IN_DISCOVER_ARIA_LABEL,
href: openInDiscoverLink,
dataTestSubj: 'unifiedDocViewerSpanLinksRefreshButton',
},
Expand Down
4 changes: 2 additions & 2 deletions ...unified_doc_viewer/public/components/observability/traces/components/span_links/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import { useDataSourcesContext } from '../../../../../hooks/use_data_sources';
import { useGetGenerateDiscoverLink } from '../../../../../hooks/use_generate_discover_link';
import { getColumns } from './get_columns';
import { useFetchSpanLinks } from './use_fetch_span_links';
import { OPEN_IN_DISCOVER_LABEL, OPEN_IN_DISCOVER_LABEL_ARIAL_LABEL } from '../../common/constants';
import { OPEN_IN_DISCOVER_LABEL, OPEN_IN_DISCOVER_ARIA_LABEL } from '../../common/constants';

export interface Props {
traceId: string;
Expand Down Expand Up @@ -138,7 +138,7 @@ export function SpanLinks({ docId, traceId, processorEvent }: Props) {
{
icon: 'discoverApp',
label: OPEN_IN_DISCOVER_LABEL,
ariaLabel: OPEN_IN_DISCOVER_LABEL_ARIAL_LABEL,
ariaLabel: OPEN_IN_DISCOVER_ARIA_LABEL,
href: openInDiscoverLink,
dataTestSubj: 'unifiedDocViewerSpanLinksRefreshButton',
},
Expand Down
4 changes: 2 additions & 2 deletions ...ewer/public/components/observability/traces/components/trace_context_log_events/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { useDataSourcesContext } from '../../../../../hooks/use_data_sources';
import { useLogsQuery } from '../../hooks/use_logs_query';
import { useGetGenerateDiscoverLink } from '../../../../../hooks/use_generate_discover_link';
import { createTraceContextWhereClause } from '../../common/create_trace_context_where_clause';
import { OPEN_IN_DISCOVER_LABEL, OPEN_IN_DISCOVER_LABEL_ARIAL_LABEL } from '../../common/constants';
import { OPEN_IN_DISCOVER_LABEL, OPEN_IN_DISCOVER_ARIA_LABEL } from '../../common/constants';

const logsTitle = i18n.translate('unifiedDocViewer.observability.traces.section.logs.title', {
defaultMessage: 'Logs',
Expand Down Expand Up @@ -78,7 +78,7 @@ export function TraceContextLogEvents({
{
icon: 'discoverApp',
label: OPEN_IN_DISCOVER_LABEL,
ariaLabel: OPEN_IN_DISCOVER_LABEL_ARIAL_LABEL,
ariaLabel: OPEN_IN_DISCOVER_ARIA_LABEL,
href: openInDiscoverLink,
dataTestSubj: 'unifiedDocViewerLogsOpenInDiscoverButton',
},
Expand Down
36 changes: 30 additions & 6 deletions ...ed_doc_viewer/public/components/observability/traces/components/trace_waterfall/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,15 @@
import { EuiDelayRender } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import type { DocViewRenderProps } from '@kbn/unified-doc-viewer/types';
import React, { useState } from 'react';
import React, { useMemo, useState } from 'react';
import { TRACE_ID_FIELD } from '@kbn/discover-utils';
import { useGetGenerateDiscoverLink } from '../../../../../hooks/use_generate_discover_link';
import { useDataSourcesContext } from '../../../../../hooks/use_data_sources';
import { ContentFrameworkSection } from '../../../../..';
import { getUnifiedDocViewerServices } from '../../../../../plugin';
import { FullScreenWaterfall } from '../full_screen_waterfall';
import { TraceWaterfallTourStep } from './full_screen_waterfall_tour_step';
import { OPEN_IN_DISCOVER_LABEL, OPEN_IN_DISCOVER_ARIA_LABEL } from '../../common/constants';

interface Props {
traceId: string;
Expand All @@ -38,17 +42,26 @@ const sectionTitle = i18n.translate('unifiedDocViewer.observability.traces.trace

export function TraceWaterfall({ traceId, docId, serviceName, dataView }: Props) {
const { data, discoverShared } = getUnifiedDocViewerServices();
const { indexes } = useDataSourcesContext();
const [showFullScreenWaterfall, setShowFullScreenWaterfall] = useState(false);
const { from: rangeFrom, to: rangeTo } = data.query.timefilter.timefilter.getAbsoluteTime();

const FocusedTraceWaterfall = discoverShared.features.registry.getById(
'observability-focused-trace-waterfall'
)?.render;
const [showFullScreenWaterfall, setShowFullScreenWaterfall] = useState(false);
const { from: rangeFrom, to: rangeTo } = data.query.timefilter.timefilter.getAbsoluteTime();

if (!FocusedTraceWaterfall) {
return null;
}
const { generateDiscoverLink } = useGetGenerateDiscoverLink({
indexPattern: indexes.apm.traces,
Comment thread
iblancof marked this conversation as resolved.
});

const openInDiscoverLink = useMemo(() => {
return generateDiscoverLink({ [TRACE_ID_FIELD]: traceId });
}, [generateDiscoverLink, traceId]);

const actionId = 'traceWaterfallFullScreenAction';

if (!FocusedTraceWaterfall) return null;

return (
<>
{showFullScreenWaterfall ? (
Expand Down Expand Up @@ -76,6 +89,17 @@ export function TraceWaterfall({ traceId, docId, serviceName, dataView }: Props)
id: actionId,
dataTestSubj: 'unifiedDocViewerObservabilityTracesTraceFullScreenButton',
},
...(openInDiscoverLink
? [
{
icon: 'discoverApp',
label: OPEN_IN_DISCOVER_LABEL,
ariaLabel: OPEN_IN_DISCOVER_ARIA_LABEL,
href: openInDiscoverLink,
dataTestSubj: 'unifiedDocViewerObservabilityTracesOpenInDiscoverButton',
},
]
: []),
]}
>
{docId ? (
Expand Down
Loading