[Lens as code] Merge metrics into a single property for Metric chart#249533
Merged
dej611 merged 9 commits intoelastic:mainfrom Jan 29, 2026
Merged
[Lens as code] Merge metrics into a single property for Metric chart#249533dej611 merged 9 commits intoelastic:mainfrom
dej611 merged 9 commits intoelastic:mainfrom
Conversation
dej611
added
Team:Visualizations
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
dej611
added
the
release_note:skip
Co-authored-by: Andreana Malama <andreana.malama@elastic.co>
andrimal
reviewed
Jan 20, 2026
| addLayerColumn(trendLineLayer, `${ACCESSOR}_trendline`, columns); | ||
| addLayerColumn(trendLineLayer, HISTOGRAM_COLUMN_NAME, columns); | ||
| addLayerColumn(trendLineLayer, `${ACCESSOR}_trendline`, newPrimaryColumns); | ||
| addLayerColumn(trendLineLayer, HISTOGRAM_COLUMN_NAME, newPrimaryColumns); |
Contributor
There was a problem hiding this comment.
I think here we have an issue that pre-existed and we should pass a date histogram column instead of the newPrimaryColumns here.
| addLayerColumn(defaultLayer, columnName, newSecondaryColumns); | ||
| if (trendLineLayer) { | ||
| addLayerColumn(trendLineLayer, `${columnName}_trendline`, newColumn, false, 'X0'); | ||
| addLayerColumn(trendLineLayer, `${columnName}_trendline`, newSecondaryColumns, false, 'X0'); |
Contributor
There was a problem hiding this comment.
Similar pre-existing issue, in line 191 we set
trendlineSecondaryMetricAccessor: '${ACCESSOR}_secondary_trendline', but here we are adding the 'X0' suffix to the layer name. I think we should remove the suffix.
andrimal
approved these changes
Jan 22, 2026
Contributor
andrimal
left a comment
andrimal
left a comment
There was a problem hiding this comment.
Approving to unblock, as the trendline issue was not caused by this PR.
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
kibanamachine
added
backport:skip
hannahbrooks
pushed a commit
to hannahbrooks/kibana
that referenced
this pull request
Jan 30, 2026
…lastic#249533) ## Summary Fix elastic#244506 This PR fixes few Metric chart API shortcomings: * Breakdown dimension can be ranked by secondary metric now * due to `schema` library lack of tuple support, while the `metrics` property can be an array, the introduction of the `type` discrimination property had to be done to avoid random default injections. * Fixed background chart schema for ES|QL version * Added more E2E tests (both from SO and API versions) ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Andreana Malama <andreana.malama@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #244506
This PR fixes few Metric chart API shortcomings:
schemalibrary lack of tuple support, while themetricsproperty can be an array, the introduction of thetypediscrimination property had to be done to avoid random default injections.Checklist