[9.3] [Security Solution] Installation review pagination: Backend (#247375)#249181
Merged
kibanamachine merged 4 commits intoelastic:9.3from Jan 19, 2026
Merged
[9.3] [Security Solution] Installation review pagination: Backend (#247375)#249181kibanamachine merged 4 commits intoelastic:9.3from
kibanamachine merged 4 commits intoelastic:9.3from
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
nikitaindik
force-pushed
the
backport/9.3/pr-247375
branch
from
8899c37 to
a16fdd0
Compare
…247375) **Partially addresses: elastic#241656** > **Note:** In this PR the endpoint is paginated, but `page` and `per_page` parameters are optional. If no pagination parameters are provided, it will return all rules at once (same as previous behavior). We want to release this PR first and then we'll make the pagination parameters required in a follow-up PR. ## Summary This PR adds pagination, sorting and filtering functionality to the prebuilt rules installation review endpoint (`internal/prebuilt_rules/installation/_review`) in accordance with the [API design proposal](https://docs.google.com/document/d/1AYlt8wJMoLD-V_owAd4qL-h76IOVnfDCZ77VNmmf-Ks/edit?usp=sharing) (internal). No changes to the front end in this PR. I will make frontend use backend-side pagination, sorting and filtering in a follow-up PR. ## Changes - Implemented pagination, sorting and filtering of prebuilt rules. `page` and `per_page` parameters are optional. If these parameters are not provided, endpoint will return all rules at once (same as previous behaviour). - Added mappings for more fields of `security-rule` SO: `name`, `tags`, `severity`, `risk_score` - Split Prebuilt Rule Assets client into multiple files, because it became to large - Updated existing Prebuilt Rule Assets client methods to use `savedObjectsClient.search` instead of `savedObjectsClient.find`. This allows to use the "terms" aggregation to fetch needed rules without having to work around the "max boolean clauses count reached" issue. - Covered the changes with integration tests according to the recently merged test plan ([PR](elastic#244804)) - Added a couple of new scenarios to test plans based on [suggestions](elastic#244804 (comment)) from @pborgonovi --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jean-Louis Leysens <jloleysens@gmail.com> Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co> (cherry picked from commit e1d9b59)
…tion_tests/ci_checks
**Related comment in previous PR: https://github.com/elastic/kibana/pull/247375/files#r2691131621** ## Summary Recently I've merged a PR with a mistake – the shape of the `filter` parameter is incorrect: the `values` property was missing. This PR fixes the shape and updates tests accordingly. We need to merge this before the Serverless release on Monday, 19-Jan-2026. This PR is for `main`. I will also backport these changes to the `9.3`, `9.2` and `8.19` branches by adding the change in separate PRs.
…tion_tests/ci_checks
nikitaindik
force-pushed
the
backport/9.3/pr-247375
branch
from
0f8a62e to
7e35403
Compare
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
cc @nikitaindik |
35 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation