[One Workflow] Migrate http step to new connector

.github/CODEOWNERS

@@ -2885,6 +2885,11 @@ src/platform/packages/shared/kbn-connector-schemas/thehive @elastic/kibana-cases
 /x-pack/platform/plugins/shared/stack_connectors/server/usage/inference @elastic/appex-ai-infra
 /src/platform/packages/shared/kbn-connector-schemas/inference @elastic/appex-ai-infra @elastic/security-generative-ai @elastic/obs-ai-team
 
+# HTTP
+/x-pack/platform/plugins/shared/stack_connectors/public/connector_types/http @elastic/workflows-eng
+/x-pack/platform/plugins/shared/stack_connectors/server/connector_types/http @elastic/workflows-eng
+/src/platform/packages/shared/kbn-connector-schemas/http @elastic/workflows-eng
+
 # Token tracking
 x-pack/platform/plugins/shared/actions/server/lib/token_tracking @elastic/security-generative-ai
 

src/platform/packages/shared/kbn-connector-schemas/http/constants.ts

@@ -0,0 +1,16 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+import { i18n } from '@kbn/i18n';
+
+export const CONNECTOR_ID = '.http';
+export const CONNECTOR_ID_SYSTEM = '.http-system';
+
+export const CONNECTOR_NAME = i18n.translate('connectors.http.title', {
+  defaultMessage: 'HTTP',
+});

src/platform/packages/shared/kbn-connector-schemas/http/index.ts

@@ -0,0 +1,18 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+export * from './constants';
+
+export { ConfigSchema, ParamsSchema, HTTP_METHODS } from './schemas/latest';
+
+export type {
+  ConnectorTypeConfigType,
+  ConnectorTypeSecretsType,
+  ActionParamsType,
+  HttpMethod,
+} from './types/latest';

src/platform/plugins/shared/workflows_execution_engine/server/step/http_step/index.ts → src/platform/packages/shared/kbn-connector-schemas/http/schemas/latest.ts

@@ -7,4 +7,4 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export { HttpStepImpl } from './http_step_impl';
+export { ConfigSchema, HTTP_METHODS, ParamsSchema } from './v1';

src/platform/packages/shared/kbn-connector-schemas/http/schemas/v1.ts

@@ -0,0 +1,49 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+import { z } from '@kbn/zod';
+import { AuthConfiguration } from '../../common/auth';
+
+export const HTTP_METHODS = ['GET', 'POST', 'PUT', 'PATCH', 'DELETE'] as const;
+
+export const HeadersSchema = z.record(z.string(), z.string());
+
+export const ConfigSchema = z
+  .object({
+    url: z.string().url(),
+    headers: HeadersSchema.nullable().default(null),
+    hasAuth: AuthConfiguration.hasAuth,
+    authType: AuthConfiguration.authType,
+    certType: AuthConfiguration.certType,
+    ca: AuthConfiguration.ca,
+    verificationMode: AuthConfiguration.verificationMode,
+    accessTokenUrl: AuthConfiguration.accessTokenUrl,
+    clientId: AuthConfiguration.clientId,
+    scope: AuthConfiguration.scope,
+    additionalFields: AuthConfiguration.additionalFields,
+  })
+  .strict();
+
+export const ParamsSchema = z
+  .object({
+    url: z.string().url().optional(),
+    path: z.string().optional(),
+    method: z.enum(HTTP_METHODS).default('GET'),
+    body: z.string().optional(),
+    query: z.record(z.string(), z.string()).optional(),
+    headers: z.record(z.string(), z.string()).optional(),
+    fetcher: z
+      .object({
+        skip_ssl_verification: z.boolean().optional(),
+        follow_redirects: z.boolean().optional(),
+        max_redirects: z.number().optional(),
+        keep_alive: z.boolean().optional(),
+      })
+      .optional(),
+  })
+  .strict();

src/platform/packages/shared/kbn-connector-schemas/http/types/latest.ts

@@ -0,0 +1,15 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+export type {
+  ConnectorTypeConfigType,
+  ConnectorTypeSecretsType,
+  ActionParamsType,
+  HttpMethod,
+} from './v1';

src/platform/packages/shared/kbn-connector-schemas/http/types/v1.ts

@@ -0,0 +1,23 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+import type { z } from '@kbn/zod';
+import type { SecretConfigurationSchema } from '../../common/auth';
+import type { ConfigSchema, HTTP_METHODS, ParamsSchema } from '../schemas/v1';
+
+// http method definition
+export type HttpMethod = (typeof HTTP_METHODS)[number];
+
+// config definition
+export type ConnectorTypeConfigType = z.infer<typeof ConfigSchema>;
+
+// secrets definition
+export type ConnectorTypeSecretsType = z.infer<typeof SecretConfigurationSchema>;
+
+// params definition
+export type ActionParamsType = z.infer<typeof ParamsSchema>;

src/platform/packages/shared/kbn-connector-schemas/index.ts

@@ -14,6 +14,7 @@ export { CONNECTOR_ID as D3SecurityConnectorTypeId } from './d3security';
 export { CONNECTOR_ID as EmailConnectorTypeId } from './email';
 export { CONNECTOR_ID as EsIndexConnectorTypeId } from './es_index';
 export { CONNECTOR_ID as GeminiConnectorTypeId } from './gemini';
+export { CONNECTOR_ID as HttpConnectorTypeId } from './http';
 export { CONNECTOR_ID as InferenceConnectorTypeId } from './inference';
 export { CONNECTOR_ID as JiraConnectorTypeId } from './jira';
 export { CONNECTOR_ID as JiraServiceManagementConnectorTypeId } from './jira-service-management';

src/platform/packages/shared/kbn-workflows/common/constants.ts

@@ -24,3 +24,11 @@ export const WORKFLOWS_UI_SHOW_EXECUTOR_SETTING_ID = 'workflows:ui:showExecutor:
  * Feature flag ID for enabling / disabling the workflow execution stats bar UI
  */
 export const WORKFLOW_EXECUTION_STATS_BAR_SETTING_ID = 'workflows:executionStatsBar:enabled';
+
+/**
+ * Map of regular (saved object) connector types -> their system connector equivalents.
+ * Use this map to make the `connector-id` step config property optional for a given connector step type, allowing it to be executed via its linked system connector.
+ * Pre-requisite for this to work:
+ * - System connectors have empty config/secrets schemas. Make sure these system connectors are able to execute by receiving params alone.
+ */
+export const SystemConnectorsMap = new Map<string, string>([['.http', '.http-system']]);

src/platform/packages/shared/kbn-workflows/graph/build_execution_graph/build_execution_graph.ts

@@ -14,7 +14,6 @@ import type {
   DataSetStep,
   ElasticsearchStep,
   ForEachStep,
-  HttpStep,
   IfStep,
   KibanaStep,
   StepWithForeach,
@@ -50,7 +49,6 @@ import type {
   ExitTimeoutZoneNode,
   ExitTryBlockNode,
   GraphNodeUnion,
-  HttpGraphNode,
   KibanaGraphNode,
   WaitGraphNode,
   WorkflowGraphType,
@@ -142,10 +140,6 @@ function visitAbstractStep(currentStep: BaseStep, context: GraphBuildContext): W
     return visitDataSetStep(currentStep as DataSetStep, context);
   }
 
-  if ((currentStep as HttpStep).type === 'http') {
-    return visitHttpStep(currentStep as HttpStep, context);
-  }
-
   if ((currentStep as ElasticsearchStep).type?.startsWith('elasticsearch.')) {
     return visitElasticsearchStep(currentStep as ElasticsearchStep, context);
   }
@@ -197,26 +191,6 @@ export function visitDataSetStep(
   return graph;
 }
 
-export function visitHttpStep(
-  currentStep: HttpStep,
-  context: GraphBuildContext
-): WorkflowGraphType {
-  const stepId = getStepId(currentStep, context);
-  const graph = createTypedGraph({ directed: true });
-  const httpNode: HttpGraphNode = {
-    id: getStepId(currentStep, context),
-    type: 'http',
-    stepId,
-    stepType: currentStep.type,
-    configuration: {
-      ...currentStep,
-    },
-  };
-  graph.setNode(httpNode.id, httpNode);
-
-  return graph;
-}
-
 export function visitElasticsearchStep(
   currentStep: ElasticsearchStep,
   context: GraphBuildContext

src/platform/packages/shared/kbn-workflows/graph/build_execution_graph/tests/build_execution_graph.test.ts

@@ -12,7 +12,6 @@ import type {
   ConnectorStep,
   ElasticsearchStep,
   ForEachStep,
-  HttpStep,
   IfStep,
   KibanaStep,
   WaitStep,
@@ -27,7 +26,6 @@ import type {
   ExitConditionBranchNode,
   ExitForeachNode,
   ExitIfNode,
-  HttpGraphNode,
   KibanaGraphNode,
   WaitGraphNode,
 } from '../../types';
@@ -149,80 +147,6 @@ describe('convertToWorkflowGraph', () => {
     });
   });
 
-  describe('http step', () => {
-    const workflowDefinition = {
-      steps: [
-        {
-          name: 'testAtomicStep1',
-          type: 'slack',
-          connectorId: 'slack',
-          with: {
-            message: 'Hello from atomic step 1',
-          },
-        } as ConnectorStep,
-        {
-          name: 'testHttpStep',
-          type: 'http',
-          with: {
-            url: 'https://api.example.com/test',
-            method: 'GET',
-            headers: {
-              Authorization: 'Bearer token',
-            },
-            timeout: '30s',
-          },
-        } as HttpStep,
-        {
-          name: 'testAtomicStep2',
-          type: 'slack',
-          connectorId: 'slack',
-          with: {
-            message: 'Hello from atomic step 2',
-          },
-        } as ConnectorStep,
-      ],
-    } as Partial<WorkflowYaml>;
-
-    it('should return nodes for http step in correct topological order', () => {
-      const executionGraph = convertToWorkflowGraph(workflowDefinition as any);
-      const topSort = graphlib.alg.topsort(executionGraph);
-      expect(topSort).toHaveLength(3);
-      expect(topSort).toEqual(['testAtomicStep1', 'testHttpStep', 'testAtomicStep2']);
-    });
-
-    it('should return correct edges for http step graph', () => {
-      const executionGraph = convertToWorkflowGraph(workflowDefinition as any);
-      const edges = executionGraph.edges();
-      expect(edges).toEqual([
-        { v: 'testAtomicStep1', w: 'testHttpStep' },
-        { v: 'testHttpStep', w: 'testAtomicStep2' },
-      ]);
-    });
-
-    it('should configure the http step correctly', () => {
-      const executionGraph = convertToWorkflowGraph(workflowDefinition as any);
-      const node = executionGraph.node('testHttpStep');
-      expect(node).toEqual({
-        id: 'testHttpStep',
-        type: 'http',
-        stepId: 'testHttpStep',
-        stepType: 'http',
-        configuration: {
-          name: 'testHttpStep',
-          type: 'http',
-          with: {
-            url: 'https://api.example.com/test',
-            method: 'GET',
-            headers: {
-              Authorization: 'Bearer token',
-            },
-            timeout: '30s',
-          },
-        },
-      } as HttpGraphNode);
-    });
-  });
-
   describe('if step', () => {
     const workflowDefinition = {
       steps: [

src/platform/packages/shared/kbn-workflows/graph/index.ts

@@ -33,8 +33,6 @@ export type {
   ExitContinueNode,
   WaitGraphNodeSchema,
   WaitGraphNode,
-  HttpGraphNode,
-  HttpGraphNodeSchema,
   EnterTryBlockNode,
   ExitTryBlockNode,
   EnterNormalPathNode,
@@ -51,7 +49,6 @@ export {
   isDataSet,
   isElasticsearch,
   isKibana,
-  isHttp,
   isWait,
   isEnterForeach,
   isEnterIf,

src/platform/packages/shared/kbn-workflows/graph/types/guards.ts

@@ -11,7 +11,6 @@ import type {
   AtomicGraphNode,
   DataSetGraphNode,
   ElasticsearchGraphNode,
-  HttpGraphNode,
   KibanaGraphNode,
   WaitGraphNode,
 } from './nodes/base';
@@ -44,8 +43,6 @@ export const isElasticsearch = (node: GraphNodeUnion): node is ElasticsearchGrap
 export const isKibana = (node: GraphNodeUnion): node is KibanaGraphNode =>
   node.type.startsWith('kibana.');
 
-export const isHttp = (node: GraphNodeUnion): node is HttpGraphNode => node.type === 'http';
-
 export const isWait = (node: GraphNodeUnion): node is WaitGraphNode => node.type === 'wait';
 
 export const isDataSet = (node: GraphNodeUnion): node is DataSetGraphNode =>

src/platform/packages/shared/kbn-workflows/graph/types/index.ts

@@ -12,8 +12,6 @@ export type {
   AtomicGraphNodeSchema,
   DataSetGraphNode,
   DataSetGraphNodeSchema,
-  HttpGraphNode,
-  HttpGraphNodeSchema,
   WaitGraphNode,
   WaitGraphNodeSchema,
   ElasticsearchGraphNode,
@@ -71,7 +69,6 @@ export {
   isDataSet,
   isElasticsearch,
   isKibana,
-  isHttp,
   isWait,
   isEnterForeach,
   isEnterIf,

src/platform/packages/shared/kbn-workflows/graph/types/nodes/base.ts

@@ -11,7 +11,6 @@ import { z } from '@kbn/zod/v4';
 import {
   DataSetStepSchema,
   ElasticsearchStepSchema,
-  HttpStepSchema,
   KibanaStepSchema,
   WaitStepSchema,
 } from '../../../spec/schema';
@@ -44,13 +43,6 @@ export const DataSetGraphNodeSchema = GraphNodeSchema.extend({
 });
 export type DataSetGraphNode = z.infer<typeof DataSetGraphNodeSchema>;
 
-export const HttpGraphNodeSchema = GraphNodeSchema.extend({
-  id: z.string(),
-  type: z.literal('http'),
-  configuration: HttpStepSchema,
-});
-export type HttpGraphNode = z.infer<typeof HttpGraphNodeSchema>;
-
 export const ElasticsearchGraphNodeSchema = GraphNodeSchema.extend({
   id: z.string(),
   type: z.string().refine((val) => val.startsWith('elasticsearch.'), {