[Obs Explorations] Fix incorrect extraction of time range from wrong context#248939
Merged
achyutjhunjhunwala merged 3 commits intoelastic:mainfrom Jan 14, 2026
Conversation
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
|
weltenwort
approved these changes
Jan 14, 2026
Member
weltenwort
left a comment
There was a problem hiding this comment.
I verified the fix via context menu in the categories page. I left one question below that might be relevant for backporting. Otherwise LGTM, thanks a lot!
.../solutions/observability/plugins/infra/public/pages/logs/stream/page_view_log_in_context.tsx
Show resolved
Hide resolved
Contributor
|
Starting backport for target branches: 9.1, 9.2, 9.3 https://github.com/elastic/kibana/actions/runs/20995692482 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 14, 2026
…context (elastic#248939) ## Summary Original issue - elastic#248795 As part of the original issue it was found that in 8.19 it provides a completely broken experience but 9.1 onwards, we don't access the undefined object inside the react component and straight away were passing it to the Discover Locator which was getting `undefined` for `dateRange` and thus was defaulting to `now to now-15m` With this PR we fix passing the correct `dateRange`. Now when user open `View in Context` and then clicks Open in Discover from the modal, it does passes the actual timerange from the Logs Categories page to Discover ## Release Note Fixes broken links from View In Context Modal to Discover which was not respecting the DateRange (cherry picked from commit 6302c6b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 14, 2026
…context (elastic#248939) ## Summary Original issue - elastic#248795 As part of the original issue it was found that in 8.19 it provides a completely broken experience but 9.1 onwards, we don't access the undefined object inside the react component and straight away were passing it to the Discover Locator which was getting `undefined` for `dateRange` and thus was defaulting to `now to now-15m` With this PR we fix passing the correct `dateRange`. Now when user open `View in Context` and then clicks Open in Discover from the modal, it does passes the actual timerange from the Logs Categories page to Discover ## Release Note Fixes broken links from View In Context Modal to Discover which was not respecting the DateRange (cherry picked from commit 6302c6b)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 14, 2026
…context (elastic#248939) ## Summary Original issue - elastic#248795 As part of the original issue it was found that in 8.19 it provides a completely broken experience but 9.1 onwards, we don't access the undefined object inside the react component and straight away were passing it to the Discover Locator which was getting `undefined` for `dateRange` and thus was defaulting to `now to now-15m` With this PR we fix passing the correct `dateRange`. Now when user open `View in Context` and then clicks Open in Discover from the modal, it does passes the actual timerange from the Logs Categories page to Discover ## Release Note Fixes broken links from View In Context Modal to Discover which was not respecting the DateRange (cherry picked from commit 6302c6b)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 15, 2026
…wrong context (#248939) (#249008) # Backport This will backport the following commits from `main` to `9.2`: - [[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)](#248939) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2026-01-14T13:23:56Z","message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","v9.3.0","Team:obs-exploration","v9.4.0","v9.1.10","v9.2.5"],"title":"[Obs Explorations] Fix incorrect extraction of time range from wrong context","number":248939,"url":"https://github.com/elastic/kibana/pull/248939","mergeCommit":{"message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.1","9.2"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248939","number":248939,"mergeCommit":{"message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144"}},{"branch":"9.1","label":"v9.1.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jan 15, 2026
…wrong context (#248939) (#249009) # Backport This will backport the following commits from `main` to `9.3`: - [[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)](#248939) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2026-01-14T13:23:56Z","message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","v9.3.0","Team:obs-exploration","v9.4.0","v9.1.10","v9.2.5"],"title":"[Obs Explorations] Fix incorrect extraction of time range from wrong context","number":248939,"url":"https://github.com/elastic/kibana/pull/248939","mergeCommit":{"message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.1","9.2"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248939","number":248939,"mergeCommit":{"message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144"}},{"branch":"9.1","label":"v9.1.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Jan 15, 2026
…wrong context (#248939) (#249007) # Backport This will backport the following commits from `main` to `9.1`: - [[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)](#248939) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Achyut Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2026-01-14T13:23:56Z","message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144","branchLabelMapping":{"^v9.4.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:version","v9.3.0","Team:obs-exploration","v9.4.0","v9.1.10","v9.2.5"],"title":"[Obs Explorations] Fix incorrect extraction of time range from wrong context","number":248939,"url":"https://github.com/elastic/kibana/pull/248939","mergeCommit":{"message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.1","9.2"],"targetPullRequestStates":[{"branch":"9.3","label":"v9.3.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.4.0","branchLabelMappingKey":"^v9.4.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/248939","number":248939,"mergeCommit":{"message":"[Obs Explorations] Fix incorrect extraction of time range from wrong context (#248939)\n\n## Summary\n\nOriginal issue - https://github.com/elastic/kibana/pull/248795\n\nAs part of the original issue it was found that in 8.19 it provides a\ncompletely broken experience but 9.1 onwards, we don't access the\nundefined object inside the react component and straight away were\npassing it to the Discover Locator which was getting `undefined` for\n`dateRange` and thus was defaulting to `now to now-15m`\n\nWith this PR we fix passing the correct `dateRange`. Now when user open\n`View in Context` and then clicks Open in Discover from the modal, it\ndoes passes the actual timerange from the Logs Categories page to\nDiscover\n\n## Release Note\n\nFixes broken links from View In Context Modal to Discover which was not\nrespecting the DateRange","sha":"6302c6b9a02a26e533f805926752d28a0c0b0144"}},{"branch":"9.1","label":"v9.1.10","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
smith
pushed a commit
to smith/kibana
that referenced
this pull request
Jan 16, 2026
…context (elastic#248939) ## Summary Original issue - elastic#248795 As part of the original issue it was found that in 8.19 it provides a completely broken experience but 9.1 onwards, we don't access the undefined object inside the react component and straight away were passing it to the Discover Locator which was getting `undefined` for `dateRange` and thus was defaulting to `now to now-15m` With this PR we fix passing the correct `dateRange`. Now when user open `View in Context` and then clicks Open in Discover from the modal, it does passes the actual timerange from the Logs Categories page to Discover ## Release Note Fixes broken links from View In Context Modal to Discover which was not respecting the DateRange
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Original issue - #248795
As part of the original issue it was found that in 8.19 it provides a completely broken experience but 9.1 onwards, we don't access the undefined object inside the react component and straight away were passing it to the Discover Locator which was getting
undefinedfordateRangeand thus was defaulting tonow to now-15mWith this PR we fix passing the correct
dateRange. Now when user openView in Contextand then clicks Open in Discover from the modal, it does passes the actual timerange from the Logs Categories page to DiscoverRelease Note
Fixes broken links from View In Context Modal to Discover which was not respecting the DateRange