-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[ResponseOps] Alerting v2: Initialize all resources #248696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cnasikas
merged 14 commits into
elastic:alerting_v2
from
cnasikas:alerting_v2_resources
Jan 14, 2026
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c59da28
Make the resource service generic
cnasikas 77d0b3e
Register alert transitions and events resources
cnasikas bc8d911
Catch errors so Kibana does not crush
cnasikas 8fb3b42
Rename ResourcesService to ResourcesService
cnasikas ed3ef2f
Minor tweaks
cnasikas 13389f6
Add more tests
cnasikas 3de5b39
Changes from node scripts/lint_ts_projects --fix
kibanamachine 546ae5f
Fix types
cnasikas bca87c2
Merge branch 'alerting_v2_resources' of github.com:cnasikas/kibana in…
cnasikas 277217b
Fix feature privilege integration tests
cnasikas cbfdc1a
Fix CI errors
cnasikas 994e091
Make resources hidden
cnasikas a8304cd
Fix Privileges tests
cnasikas 90a5604
PR feedback
cnasikas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 0 additions & 65 deletions
65
x-pack/platform/plugins/shared/alerting_v2/server/lib/rule_executor/resources.ts
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
142 changes: 0 additions & 142 deletions
142
x-pack/platform/plugins/shared/alerting_v2/server/lib/services/alerting_resources_service.ts
This file was deleted.
Oops, something went wrong.
17 changes: 17 additions & 0 deletions
17
x-pack/platform/plugins/shared/alerting_v2/server/lib/services/es_service/tokens.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import type { ElasticsearchClient } from '@kbn/core/server'; | ||
| import type { ServiceIdentifier } from 'inversify'; | ||
|
|
||
| export const EsServiceInternalToken = Symbol.for( | ||
| 'alerting_v2.EsServiceInternal' | ||
| ) as ServiceIdentifier<ElasticsearchClient>; | ||
|
|
||
| export const EsServiceScopedToken = Symbol.for( | ||
| 'alerting_v2.EsServiceScoped' | ||
| ) as ServiceIdentifier<ElasticsearchClient>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I updated the task definition to use DI here #248866
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How should I approach it? Merge this PR and then in your PR update with the new task definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just FYI, I update my PR after we merge this one