[App Menu Standardization] Handle export funcionality#248556
Merged
kowalczyk-krzysztof merged 5 commits intoelastic:mainfrom Jan 12, 2026
Merged
[App Menu Standardization] Handle export funcionality#248556kowalczyk-krzysztof merged 5 commits intoelastic:mainfrom
kowalczyk-krzysztof merged 5 commits intoelastic:mainfrom
Conversation
kowalczyk-krzysztof
added
release_note:skip
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
kowalczyk-krzysztof
force-pushed
the
feat/app-menu-legacy-support
branch
3 times, most recently
from
b099a37 to
1ee1314
Compare
kowalczyk-krzysztof
changed the title
kowalczyk-krzysztof
force-pushed
the
feat/app-menu-legacy-support
branch
6 times, most recently
from
1772b5e to
f388ff2
Compare
kowalczyk-krzysztof
force-pushed
the
feat/app-menu-legacy-support
branch
from
f388ff2 to
d3630a5
Compare
Dosant
approved these changes
Jan 12, 2026
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
eokoneyo
reviewed
Jan 12, 2026
Comment on lines
+171
to
+177
| if ( | ||
| !derivative || | ||
| derivative.shareType !== 'integration' || | ||
| derivative.groupId !== 'exportDerivatives' | ||
| ) { | ||
| return null; | ||
| } |
Contributor
There was a problem hiding this comment.
it should be sufficient to check no derivative was found here
Member
Author
There was a problem hiding this comment.
Yeah this is redundant, changed. Thanks
Comment on lines
+90
to
+92
| const exportIntegration = menuItems.find( | ||
| (item) => item.shareType === 'integration' && item.id === exportId | ||
| ); |
Contributor
There was a problem hiding this comment.
Since export derivatives has it's own handler, do we want to exclude export derivatives here?
Member
Author
There was a problem hiding this comment.
That's true, changed the implementation to exclude derivatives. Thanks.
Contributor
There was a problem hiding this comment.
Sorry man... I think I should have phrased the initial suggestion properly, it's best we specifically select for integrations of groupId export, especially that it's technically possible to have integrations have the same id as long as they specify different groupIds
Member
Author
There was a problem hiding this comment.
Got it, I'll update it.
kowalczyk-krzysztof
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
sepErator->sepArator,top-navprefixed test subjects in app menu toapp-menuprefix,popoverTestIdproperty,anchorElement) popoverCloses: https://github.com/elastic/kibana-team/issues/2618