[Defend Workflows][Trusted Apps][Exceptions builder][Bug] Trusted apps allows for copy paste in advanced mode conditions values by parkiino · Pull Request #248537 · elastic/kibana

parkiino · 2026-01-09T20:53:38Z

Summary

Copy pasted values are properly updated into the Trusted Apps matches operator values and saved
Refactors the trusted apps form exception builder handler to properly handle duplicate condition entries and shows the "Wildcard with wrong operator" callout in basic mode

Screenshots

elasticmachine · 2026-01-09T20:54:57Z

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

…ug/ta-copy-paste

rylnd

Detection Engine code changes LGTM; just had one question about a logical change (seemingly) tangential to the intent of the PR.

rylnd · 2026-01-13T21:26:07Z

...tions/security/packages/kbn-securitysolution-autocomplete/src/field_value_wildcard/index.tsx

        const [newValue] = newOptions.map(({ label }) => optionsMemo[labels.indexOf(label)]);
        handleError(undefined);
        handleSpacesWarning(newValue);
-        setShowSpacesWarning(false);


Did you find that this state change was unnecessary? We still call it in several other places, here and I didn't see any explanation on why it was removed.

Yeah i found it unnecessary since setShowSpaces is called in handleSpacesWarning anyways.

rylnd · 2026-01-13T21:28:52Z

...olutions/security/packages/kbn-securitysolution-autocomplete/src/field_value_match/index.tsx

-// TODO: I have to use any here for now, but once this is available below, we should use the correct types, https://github.com/elastic/kibana/issues/100715
-// import { AutocompleteStart } from '../../../../../../../../../../src/plugins/unified_search/public';
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-type AutocompleteStart = any;


Fantastic! 🥇

…ug/ta-copy-paste

gergoabraham

hey @parkiino,

just tested this and it seems that the issue is still present. it does not come up with the IS, only with the MATCHES operator

Screen.Recording.2026-02-23.at.17.11.16.mov

parkiino · 2026-02-24T06:09:42Z

hey @parkiino,

just tested this and it seems that the issue is still present. it does not come up with the IS, only with the MATCHES operator

Screen.Recording.2026-02-23.at.17.11.16.mov

Good catch Gergo! It seems I accidentally got rid of some code during a merge upstream 😵‍💫. If possible, would you be able to retest? I think it should work now.

gergoabraham

hey @parkiino,

after you fix the lint error, it's gonna work well.

it's always worth to play around a bit before (re)opening for review, and also when merging upstream, to see if everything still works as expected

gergoabraham · 2026-02-24T10:15:38Z

...plugins/security_solution/public/management/pages/trusted_apps/view/components/form.test.tsx

Good catch Gergo! It seems I accidentally got rid of some code during a merge upstream 😵‍💫. If possible, would you be able to retest? I think it should work now.

please make sure to add automated tests, that catch if the feature is not working anymore.

…ug/ta-copy-paste

elasticmachine · 2026-02-25T15:15:52Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lists`	64.3KB	64.3KB	+4.0B
`securitySolution`	11.1MB	11.2MB	+633.0B
total			+637.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`@kbn/securitysolution-autocomplete`	6	4	-2

Total ESLint disabled count

id	before	after	diff
`@kbn/securitysolution-autocomplete`	6	4	-2

History

💚 Build #400108 succeeded 5158c42
💔 Build #400071 failed 5c18f2d
💔 Build #399763 failed 3ba39e5
💚 Build #397479 succeeded ce0ce87
💚 Build #397328 succeeded 4d0702c

ashokaditya

Tested the copy paste and it works as expected.

gergoabraham

looking good! thanks for adding the tests 🚀

…s allows for copy paste in advanced mode conditions values (elastic#248537) ## Summary - [x] Copy pasted values are properly updated into the Trusted Apps matches operator values and saved - [x] Refactors the trusted apps form exception builder handler to properly handle duplicate condition entries and shows the "Wildcard with wrong operator" callout in basic mode # Screenshots ![copypaste](https://github.com/user-attachments/assets/131976e4-134d-4410-a46e-a9b9ab1c22c0) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

parkiino added 4 commits December 5, 2025 19:31

working copy paste w/ console logs

01d1a5f

Merge remote-tracking branch 'upstream/main' into bug/ta-copy-paste

c906ff9

wip adjust builder handler in trusted apps form

c4376ed

remove console logs and commented out code

d263392

parkiino requested review from a team as code owners January 9, 2026 20:53

parkiino requested review from paul-tavares, rylnd and tomsonpl January 9, 2026 20:53

parkiino added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution ci:cloud-deploy Create or update a Cloud deployment labels Jan 9, 2026

kibanamachine and others added 6 commits January 9, 2026 21:04

Changes from node scripts/lint_ts_projects --fix

15c749b

Changes from node scripts/regenerate_moon_projects.js --update

23dd8b4

fix linting

cdda7ed

Merge branch 'bug/ta-copy-paste' of github.com:parkiino/kibana into b…

dde8c1c

…ug/ta-copy-paste

Merge remote-tracking branch 'upstream/main' into bug/ta-copy-paste

babb1be

Merge remote-tracking branch 'upstream/main' into bug/ta-copy-paste

11a9e00

rylnd approved these changes Jan 13, 2026

View reviewed changes

parkiino and others added 9 commits January 14, 2026 15:59

Merge remote-tracking branch 'upstream/main' into bug/ta-copy-paste

fb29d85

fix actual linting -- save was not working on ide previously

4462c9b

Changes from node scripts/eslint_all_files --no-cache --fix

c1f2a86

Merge remote-tracking branch 'upstream/main' into bug/ta-copy-paste

0682859

adjust import

502b30f

linting

0a7f786

Merge branch 'bug/ta-copy-paste' of github.com:parkiino/kibana into b…

5ec37db

…ug/ta-copy-paste

Changes from node scripts/lint_ts_projects --fix

89818ec

Changes from node scripts/regenerate_moon_projects.js --update

8a6d5c1

elasticmachine and others added 2 commits February 12, 2026 16:14

Merge branch 'main' into bug/ta-copy-paste

359275d

Merge branch 'main' into bug/ta-copy-paste

3de0186

parkiino enabled auto-merge (squash) February 17, 2026 06:22

parkiino added 2 commits February 17, 2026 10:36

Merge branch 'main' into bug/ta-copy-paste

6e71a7c

Merge branch 'main' into bug/ta-copy-paste

6a0657e

parkiino disabled auto-merge February 18, 2026 06:39

parkiino and others added 3 commits February 18, 2026 15:01

update cypress test

0f517e4

Changes from node scripts/eslint_all_files --no-cache --fix

4d0702c

Merge branch 'main' into bug/ta-copy-paste

ce0ce87

parkiino enabled auto-merge (squash) February 19, 2026 05:52

parkiino disabled auto-merge February 19, 2026 05:52

parkiino requested a review from ashokaditya February 20, 2026 16:17

gergoabraham reviewed Feb 23, 2026

View reviewed changes

put back code that was accidentally erased during merge

3ba39e5

parkiino requested a review from gergoabraham February 24, 2026 06:09

gergoabraham reviewed Feb 24, 2026

View reviewed changes

parkiino and others added 4 commits February 24, 2026 09:11

fix linting

5c18f2d

Changes from node scripts/eslint_all_files --no-cache --fix

6ade155

add unit test

5f43588

Merge branch 'bug/ta-copy-paste' of github.com:parkiino/kibana into b…

5158c42

…ug/ta-copy-paste

parkiino requested review from gergoabraham and rylnd February 25, 2026 14:25

Merge branch 'main' into bug/ta-copy-paste

cef758e

ashokaditya approved these changes Feb 25, 2026

View reviewed changes

gergoabraham approved these changes Feb 25, 2026

View reviewed changes

parkiino merged commit 5766f41 into elastic:main Feb 25, 2026
16 checks passed

kibanamachine added the v9.4.0 label Feb 25, 2026

Conversation

parkiino commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Screenshots

Uh oh!

elasticmachine commented Jan 9, 2026

Uh oh!

rylnd left a comment

Choose a reason for hiding this comment

Uh oh!

rylnd Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

parkiino Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

rylnd Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

gergoabraham left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

parkiino commented Feb 24, 2026

Uh oh!

gergoabraham left a comment

Choose a reason for hiding this comment

Uh oh!

gergoabraham Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

ashokaditya left a comment

Choose a reason for hiding this comment

Uh oh!

gergoabraham left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

parkiino commented Jan 9, 2026 •

edited

Loading

gergoabraham left a comment •

edited

Loading

elasticmachine commented Feb 25, 2026 •

edited

Loading